Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: src/interface.h

Issue 345513003: Revert "Parser: Delay internalizing strings and values." (r21841) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | src/interface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interface.h
diff --git a/src/interface.h b/src/interface.h
index f79274ef7fe6e24582133757995348841786f2fb..086facf6665b1d189c24914d9a62a1d564e22133 100644
--- a/src/interface.h
+++ b/src/interface.h
@@ -5,7 +5,6 @@
#ifndef V8_INTERFACE_H_
#define V8_INTERFACE_H_
-#include "src/ast-value-factory.h"
#include "src/zone-inl.h" // For operator new.
namespace v8 {
@@ -60,9 +59,8 @@ class Interface : public ZoneObject {
// Add a name to the list of exports. If it already exists, unify with
// interface, otherwise insert unless this is closed.
- void Add(const AstString* name, Interface* interface, Zone* zone,
- bool* ok) {
- DoAdd(name, name->hash(), interface, zone, ok);
+ void Add(Handle<String> name, Interface* interface, Zone* zone, bool* ok) {
+ DoAdd(name.location(), name->Hash(), interface, zone, ok);
}
// Unify with another interface. If successful, both interface objects will
@@ -148,9 +146,9 @@ class Interface : public ZoneObject {
class Iterator {
public:
bool done() const { return entry_ == NULL; }
- const AstString* name() const {
+ Handle<String> name() const {
ASSERT(!done());
- return static_cast<const AstString*>(entry_->key);
+ return Handle<String>(*static_cast<String**>(entry_->key));
}
Interface* interface() const {
ASSERT(!done());
@@ -209,7 +207,7 @@ class Interface : public ZoneObject {
return result;
}
- void DoAdd(const void* name, uint32_t hash, Interface* interface, Zone* zone,
+ void DoAdd(void* name, uint32_t hash, Interface* interface, Zone* zone,
bool* ok);
void DoUnify(Interface* that, bool* ok, Zone* zone);
};
« no previous file with comments | « src/hydrogen.cc ('k') | src/interface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698