Issue 345513003: Revert "Parser: Delay internalizing strings and values." (r21841)

Issue 345513003: Revert "Parser: Delay internalizing strings and values." (r21841) (Closed)

Created:
6 years, 6 months ago by marja

Modified:
6 years, 6 months ago

Reviewers:
rossberg

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Parser: Delay internalizing strings and values." (r21841) Plus the fixes on top. Reason: regresses benchmarks (JSBench) and perf (morejs). TBR=rossberg@chromium.org BUG=385404 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21882

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+641 lines, -1547 lines)			Patch
M	BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	include/v8.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ast.h	View	45 chunks	+81 lines, -156 lines	0 comments	Download
M	src/ast.cc	View	7 chunks	+20 lines, -14 lines	0 comments	Download
D	src/ast-value-factory.h	View	1 chunk	+0 lines, -297 lines	0 comments	Download
D	src/ast-value-factory.cc	View	1 chunk	+0 lines, -368 lines	0 comments	Download
M	src/compiler.h	View	3 chunks	+0 lines, -11 lines	0 comments	Download
M	src/compiler.cc	View	5 chunks	+4 lines, -13 lines	0 comments	Download
M	src/func-name-inferrer.h	View	4 chunks	+13 lines, -10 lines	0 comments	Download
M	src/func-name-inferrer.cc	View	2 chunks	+36 lines, -91 lines	0 comments	Download
M	src/heap.h	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/interface.h	View	4 chunks	+5 lines, -7 lines	0 comments	Download
M	src/interface.cc	View	4 chunks	+15 lines, -9 lines	0 comments	Download
M	src/objects.cc	View	2 chunks	+39 lines, -2 lines	0 comments	Download
M	src/parser.h	View	15 chunks	+51 lines, -61 lines	0 comments	Download
M	src/parser.cc	View	106 chunks	+227 lines, -251 lines	0 comments	Download
M	src/preparser.h	View	12 chunks	+16 lines, -20 lines	0 comments	Download
M	src/prettyprinter.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/prettyprinter.cc	View	6 chunks	+4 lines, -10 lines	0 comments	Download
M	src/rewriter.cc	View	3 chunks	+4 lines, -8 lines	0 comments	Download
M	src/scanner.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/scanner.cc	View	2 chunks	+15 lines, -9 lines	0 comments	Download
M	src/scopeinfo.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/scopes.h	View	13 chunks	+19 lines, -23 lines	0 comments	Download
M	src/scopes.cc	View	36 chunks	+64 lines, -78 lines	0 comments	Download
M	src/utils.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	src/utils.cc	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	src/variables.h	View	4 chunks	+3 lines, -5 lines	0 comments	Download
M	src/variables.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	test/cctest/test-ast.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-parsing.cc	View	3 chunks	+1 line, -21 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/parser-shell.cc	View	2 chunks	+1 line, -15 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

marja

6 years, 6 months ago (2014-06-18 07:31:18 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r21882 (tree was closed).

Expand Messages | Collapse Messages