Apply paper size selection for local printers on OSX.

Apply paper size selection for local printers on OSX.

BUG=239879
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278603

[Aleksey Shlyapnikov, 2014-06-18 17:45:02]

https://codereview.chromium.org/345493003/diff/20001/printing/printing_contex...
File printing/printing_context_mac.mm (right):

https://codereview.chromium.org/345493003/diff/20001/printing/printing_contex...
printing/printing_context_mac.mm:261: if (current_printer == nil)
nil -> NULL?

https://codereview.chromium.org/345493003/diff/20001/printing/printing_contex...
printing/printing_context_mac.mm:266: return false;
Move down to the first use.

https://codereview.chromium.org/345493003/diff/20001/printing/printing_contex...
printing/printing_context_mac.mm:304: &paper) != noErr) {
What for paper is created here? It's released on the next line.

[Vitaly Buka (NO REVIEWS), 2014-06-19 00:39:09]

https://codereview.chromium.org/345493003/diff/20001/printing/printing_contex...
File printing/printing_context_mac.mm (right):

https://codereview.chromium.org/345493003/diff/20001/printing/printing_contex...
printing/printing_context_mac.mm:261: if (current_printer == nil)
On 2014/06/18 17:45:01, Aleksey Shlyapnikov wrote:
> nil -> NULL?

should be nil

https://codereview.chromium.org/345493003/diff/20001/printing/printing_contex...
printing/printing_context_mac.mm:266: return false;
On 2014/06/18 17:45:02, Aleksey Shlyapnikov wrote:
> Move down to the first use.

Done.

https://codereview.chromium.org/345493003/diff/20001/printing/printing_contex...
printing/printing_context_mac.mm:304: &paper) != noErr) {
On 2014/06/18 17:45:01, Aleksey Shlyapnikov wrote:
> What for paper is created here? It's released on the next line.

Done.

[Aleksey Shlyapnikov, 2014-06-19 02:13:09]

lgtm

https://codereview.chromium.org/345493003/diff/100001/printing/printing_conte...
File printing/printing_context_mac.h (right):

https://codereview.chromium.org/345493003/diff/100001/printing/printing_conte...
printing/printing_context_mac.h:66: // Returns true if the paper was set else
returns false.
else -> otherwise

https://codereview.chromium.org/345493003/diff/100001/printing/printing_conte...
File printing/printing_context_mac.mm (right):

https://codereview.chromium.org/345493003/diff/100001/printing/printing_conte...
printing/printing_context_mac.mm:52: if (difference > 2)
Make it a constant with units in the name, so it's clear what are we comparing
it to.

https://codereview.chromium.org/345493003/diff/100001/printing/printing_conte...
printing/printing_context_mac.mm:271: if (media.size_microns.IsEmpty()) {
media.IsDefault().

https://codereview.chromium.org/345493003/diff/100001/printing/printing_conte...
printing/printing_context_mac.mm:302: if (media.size_microns.IsEmpty())
media.IsDefault()

[Vitaly Buka (NO REVIEWS), 2014-06-19 17:44:38]

https://codereview.chromium.org/345493003/diff/100001/printing/printing_conte...
File printing/printing_context_mac.h (right):

https://codereview.chromium.org/345493003/diff/100001/printing/printing_conte...
printing/printing_context_mac.h:66: // Returns true if the paper was set else
returns false.
On 2014/06/19 02:13:08, Aleksey Shlyapnikov wrote:
> else -> otherwise

Done.

https://codereview.chromium.org/345493003/diff/100001/printing/printing_conte...
File printing/printing_context_mac.mm (right):

https://codereview.chromium.org/345493003/diff/100001/printing/printing_conte...
printing/printing_context_mac.mm:52: if (difference > 2)
On 2014/06/19 02:13:08, Aleksey Shlyapnikov wrote:
> Make it a constant with units in the name, so it's clear what are we comparing
> it to.

Done.

https://codereview.chromium.org/345493003/diff/100001/printing/printing_conte...
printing/printing_context_mac.mm:271: if (media.size_microns.IsEmpty()) {
On 2014/06/19 02:13:08, Aleksey Shlyapnikov wrote:
> media.IsDefault().

Done.

https://codereview.chromium.org/345493003/diff/100001/printing/printing_conte...
printing/printing_context_mac.mm:302: if (media.size_microns.IsEmpty())
On 2014/06/19 02:13:08, Aleksey Shlyapnikov wrote:
> media.IsDefault()

Done.

[Vitaly Buka (NO REVIEWS), 2014-06-19 17:45:44]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-06-19 17:46:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/345493003/140001

[commit-bot: I haz the power, 2014-06-19 17:46:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-19 17:46:56]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Noam Samuel, 2014-06-19 18:24:07]

lgtm

[Vitaly Buka (NO REVIEWS), 2014-06-19 18:50:52]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-06-19 18:56:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/345493003/140001

[commit-bot: I haz the power, 2014-06-20 00:32:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[commit-bot: I haz the power, 2014-06-20 00:45:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-20 00:45:59]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[Vitaly Buka (NO REVIEWS), 2014-06-20 00:58:35]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-06-20 01:00:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/345493003/140001

[commit-bot: I haz the power, 2014-06-20 05:02:38]

Change committed as 278603