Delete odd assignment of IgnoreOverlayScrollbarSize

Delete odd assignment of IgnoreOverlayScrollbarSize

This code doesn't many any sense. I also added a RELEASE_ASSERT that the field
already had this value and every test passed. That means this code doesn't do
anything.

R=eseidel@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177156

[eseidel, 2014-06-27 21:54:31]

i have but one rslgtm to give.

[abarth-chromium, 2014-06-27 21:59:57]

The CQ bit was checked by abarth@chromium.org

[chrishtr, 2014-06-27 22:00:29]

https://codereview.chromium.org/345463010/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderLayerClipper.cpp (left):

https://codereview.chromium.org/345463010/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderLayerClipper.cpp:248:
parentContext.scrollbarRelevancy = IgnoreOverlayScrollbarSize; // FIXME: why?
Does IgnoreOverlayScrollbarSize ever do anything here? I can't quite find the
place where it would. ScrollableArea seems to be the only place that cares?
Anyway just checking if this is actually dead.

[commit-bot: I haz the power, 2014-06-27 22:00:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/345463010/1

[abarth-chromium, 2014-06-27 22:04:41]

On 2014/06/27 at 22:00:29, chrishtr wrote:
> Does IgnoreOverlayScrollbarSize ever do anything here? I can't quite find the
place where it would. ScrollableArea seems to be the only place that cares?
> Anyway just checking if this is actually dead.

All the callers that go through this line of code already have
IgnoreOverlayScrollbarSize set.  At least, that's what running all the tests
with a RELEASE_ASSERT on that line showed.

In case, we shouldn't get different results when we hit the cache and when we
don't hit the cache...

[commit-bot: I haz the power, 2014-06-27 22:59:56]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-06-28 00:01:11]

Change committed as 177156