Deleted SkImage::newShaderClamp: not used, not implemented.

src/image/SkImage_Codec.cpp

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkImageDecoder.h"
 #include "SkImage_Base.h"
 #include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkData.h"
 
 class SkImage_Codec : public SkImage_Base {
 public:
     static SkImage* NewEmpty();
 
     SkImage_Codec(SkData* encodedData, int width, int height);
     virtual ~SkImage_Codec();
 
     virtual void onDraw(SkCanvas*, SkScalar, SkScalar, const SkPaint*) SK_OVERRIDE;
     virtual void onDrawRectToRect(SkCanvas*, const SkRect*, const SkRect&, const SkPaint*) SK_OVERRIDE;
 
+    virtual SkShader* onNewShader(SkShader::TileMode, SkShader::TileMode) const SK_OVERRIDE;
 private:
     SkData*     fEncodedData;
     SkBitmap    fBitmap;
 
     typedef SkImage_Base INHERITED;
 };
 
 ///////////////////////////////////////////////////////////////////////////////
 
 SkImage_Codec::SkImage_Codec(SkData* data, int width, int height) : INHERITED(width, height) {
     fEncodedData = data;
     fEncodedData->ref();
 }
 
 SkImage_Codec::~SkImage_Codec() {
     fEncodedData->unref();
 }
 
+SkShader* SkImage_Codec::onNewShader(SkShader::TileMode tileX, SkShader::TileMode tileY) const {

[Justin Novosad, 2014/07/10 19:24:36]

Do you have test coverage for this guy?

[Rémi Piotaix, 2014/07/10 20:16:04]

It seems that SkImage_Codec is never used...
Method onNewShader removed from SkImage_Codec + default implementation returns
NULL.

+    return SkShader::CreateBitmapShader(fBitmap, tileX, tileY, NULL);
+}
+
 void SkImage_Codec::onDraw(SkCanvas* canvas, SkScalar x, SkScalar y, const SkPaint* paint) {
     if (!fBitmap.pixelRef()) {
         if (!SkImageDecoder::DecodeMemory(fEncodedData->bytes(), fEncodedData->size(), &fBitmap)) {
             return;
         }
     }
     canvas->drawBitmap(fBitmap, x, y, paint);
 }
 
 void SkImage_Codec::onDrawRectToRect(SkCanvas* canvas, const SkRect* src,
@@ skipping 14 matching lines @@
     }
 
     SkBitmap bitmap;
     if (!SkImageDecoder::DecodeMemory(data->bytes(), data->size(), &bitmap, kUnknown_SkColorType,
                                       SkImageDecoder::kDecodeBounds_Mode)) {
         return NULL;
     }
 
     return SkNEW_ARGS(SkImage_Codec, (data, bitmap.width(), bitmap.height()));
 }