Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 345453005: Fixed C++ type conversion. (Closed)

Created:
6 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fixed C++ type conversion. BUG=239879 TBR=noamsml Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278226

Patch Set 1 #

Patch Set 2 : Wed 06/18/2014 10:23:08.04 #

Patch Set 3 : Wed 06/18/2014 10:25:34.94 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M printing/backend/cups_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/cups_helper_unittest.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-18 06:42:52 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 6 months ago (2014-06-18 06:43:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/345453005/1
6 years, 6 months ago (2014-06-18 06:44:56 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 16:07:42 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/43073)
6 years, 6 months ago (2014-06-18 16:07:43 UTC) #5
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-18 17:18:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/345453005/1
6 years, 6 months ago (2014-06-18 17:18:42 UTC) #7
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-18 17:26:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/345453005/40001
6 years, 6 months ago (2014-06-18 17:27:59 UTC) #9
Aleksey Shlyapnikov
lgtm
6 years, 6 months ago (2014-06-18 17:29:46 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 01:29:04 UTC) #11
Message was sent while issue was closed. 
Change committed as 278226

Powered by Google App Engine
This is Rietveld 408576698