Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 345453002: Follow-up to https://codereview.chromium.org/291993003/ (Closed)

Created:
6 years, 6 months ago by Nico
Modified:
6 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Follow-up to https://codereview.chromium.org/291993003/ r271506 removed has_sse2 from the gcc file, but it remained in the tsan header. (I asked in https://codereview.chromium.org/10948035/diff/17001/base/atomicops_internals_tsan.h#newcode24 for why this struct is in this file at all.) BUG=348761, 94925 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M base/atomicops_internals_tsan.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 6 months ago (2014-06-17 19:41:12 UTC) #1
Mark Mentovai
LGTM
6 years, 6 months ago (2014-06-17 19:43:06 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 6 months ago (2014-06-17 19:51:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/345453002/1
6 years, 6 months ago (2014-06-17 19:53:32 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 23:57:07 UTC) #5
Message was sent while issue was closed.
Change committed as 277909

Powered by Google App Engine
This is Rietveld 408576698