Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 345443005: [PPAPI] Fix the CommitLayers() will never be completed issue (Closed)

Created:
6 years, 6 months ago by Peng
Modified:
6 years, 6 months ago
Reviewers:
bbudge, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, kmixter1, mknowles
Project:
chromium
Visibility:
Public.

Description

[PPAPI] Fix the CommitLayers() will never be completed issue The aync CommitLayers() call will never be completed, if no layers changed since the last call to CommitLayers(). So we have to force a commit for each CommitLayers() call. BUG=374383 R=bbudge@chromium.org, piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278224

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/renderer/pepper/pepper_compositor_host.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peng
Hi Antoine and Bill, I moved one bug fix from the test CL https://codereview.chromium.org/324983005/ to ...
6 years, 6 months ago (2014-06-18 15:11:14 UTC) #1
bbudge
lgtm https://codereview.chromium.org/345443005/diff/1/content/renderer/pepper/pepper_compositor_host.cc File content/renderer/pepper/pepper_compositor_host.cc (right): https://codereview.chromium.org/345443005/diff/1/content/renderer/pepper/pepper_compositor_host.cc#newcode373 content/renderer/pepper/pepper_compositor_host.cc:373: if (layer_->layer_tree_host()) The comment is hard to understand. ...
6 years, 6 months ago (2014-06-18 15:58:24 UTC) #2
Peng
https://codereview.chromium.org/345443005/diff/1/content/renderer/pepper/pepper_compositor_host.cc File content/renderer/pepper/pepper_compositor_host.cc (right): https://codereview.chromium.org/345443005/diff/1/content/renderer/pepper/pepper_compositor_host.cc#newcode373 content/renderer/pepper/pepper_compositor_host.cc:373: if (layer_->layer_tree_host()) On 2014/06/18 15:58:24, bbudge wrote: > The ...
6 years, 6 months ago (2014-06-18 16:05:44 UTC) #3
piman
lgtm
6 years, 6 months ago (2014-06-18 21:43:53 UTC) #4
Peng
The CQ bit was checked by penghuang@chromium.org
6 years, 6 months ago (2014-06-18 22:59:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/345443005/20001
6 years, 6 months ago (2014-06-18 23:00:45 UTC) #6
Peng
6 years, 6 months ago (2014-06-19 01:24:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r278224 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698