Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 345433002: Relax media size capability restriction to printing PDF file to Save as PDF printer. (Closed)

Created:
6 years, 6 months ago by Aleksey Shlyapnikov
Modified:
6 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Relax media size capability restriction to printing PDF file to Save as PDF printer. BUG=384430 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M chrome/browser/resources/print_preview/data/ticket_items/media_size.js View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/test/data/webui/print_preview.js View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Aleksey Shlyapnikov
6 years, 6 months ago (2014-06-17 19:08:12 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 6 months ago (2014-06-17 21:30:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/345433002/1
6 years, 6 months ago (2014-06-17 21:32:09 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 10:20:07 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/163647)
6 years, 6 months ago (2014-06-18 10:20:08 UTC) #5
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 6 months ago (2014-06-18 16:50:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/345433002/1
6 years, 6 months ago (2014-06-18 16:51:09 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 18:45:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/163761)
6 years, 6 months ago (2014-06-18 18:45:40 UTC) #9
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 6 months ago (2014-06-18 18:49:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/345433002/1
6 years, 6 months ago (2014-06-18 18:50:59 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 19:43:12 UTC) #12
Message was sent while issue was closed. 
Change committed as 278150

Powered by Google App Engine
This is Rietveld 408576698