Issue 345423006: Ignore degeneratesegments for nvprmsaa4 to unbreak the build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345423006: Ignore degeneratesegments for nvprmsaa4 to unbreak the build (Closed)

Created:
6 years, 6 months ago by Kimmo Kinnunen

Modified:
6 years, 6 months ago

Reviewers:
rmistry

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Ignore degeneratesegments for nvprmsaa4 to unbreak the build Ignore degeneratesegments for nvprmsaa4 to unbreak the build. The result image seems to be inconsistent with different Linux GTX660 builds. Ignore the test for Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release. BUG=skia:2689 Committed: https://skia.googlesource.com/skia/+/55106da359ba8cdff0e4e1f9561aff3b7fb4bb47

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Kimmo Kinnunen

Would ignoring the failing test for now be a suitable solution? Takes me a couple ...

6 years, 6 months ago (2014-06-25 11:15:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/345423006/1

6 years, 6 months ago (2014-06-25 11:19:27 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-25 11:30:41 UTC) #5

Message was sent while issue was closed.

Change committed as 55106da359ba8cdff0e4e1f9561aff3b7fb4bb47

Expand Messages | Collapse Messages