Issue 345423003: The bounding check is duplicated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345423003: The bounding check is duplicated. (Closed)

Created:
6 years, 6 months ago by zino

Modified:
6 years, 6 months ago

Reviewers:
fs, Justin Novosad

CC:
blink-reviews, aandrey+blink_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

The bounding check is duplicated. It was already checked by SkPathContainsPoint() [1]. [1] Source/platform/graphics/skia/SkiaUtils.cpp BUG=328961 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176772

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	Source/core/html/canvas/HitRegion.cpp	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

zino

Simple clean up. I'm not sure whether this is correct. what do you think about ...

6 years, 6 months ago (2014-06-23 10:31:57 UTC) #1

Justin Novosad

Yes. The contains method wraps SkPathContainsPoint, which starts with an early exit based on bounds. ...

6 years, 6 months ago (2014-06-23 13:45:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/345423003/1

6 years, 6 months ago (2014-06-23 17:10:45 UTC) #5

Message was sent while issue was closed.

Change committed as 176772