VM: Always return immutable collections from the mirrors.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 312 matching lines @@
   bool is_setter = false;
 
   for (intptr_t i = start; i < len; i++) {
     if (name.CharAt(i) == ':') {
       ASSERT(start == 0);  // Only one : is possible in getters or setters.
       if (name.CharAt(0) == 's') {
         is_setter = true;
       }
       start = i + 1;
     } else if (name.CharAt(i) == '@') {
-      ASSERT(at_pos == -1);  // Only one @ is supported.
+      // Setters should have only one @ so we know where to put the =.
+      ASSERT(!is_setter || (at_pos == -1));

[rmacnak, 2013/10/22 18:32:52]

This change allows for names of the form

_PrivateClass@123._privateConstructor@123

       at_pos = i;
     }
   }
 
   if (start == 0) {
     // This unmangled_name is fine as it is.
     return name.raw();
   }
 
   String& result =
@@ skipping 15223 matching lines @@
   return "_MirrorReference";
 }
 
 
 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
   JSONObject jsobj(stream);
 }
 
 
 }  // namespace dart