Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 345253002: Fix for Android GN build. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Fix for Android GN build. is_linux condition excludes is_android and causes the following error: In file included from ../../third_party/hunspell/src/hunspell/affentry.cxx:9:0: ../../third_party/hunspell/src/hunspell/affentry.hxx:30:105: error: converting to non-pointer type 'short unsigned int' from NULL [-Werror=conversion-null] struct hentry * check_twosfx(const char * word, int len, char in_compound, const FLAG needflag = NULL); http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/16090 So we switch back to is_posix condition, which should cover Android as well. To test an Android build: $ gn gen out/Debug_gn --args='os="android" cpu_arch="arm"' $ ninja -C out/Debug_gn BUG=None TEST=None R=brettw@chromium.org Committed: 278973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
6 years, 6 months ago (2014-06-21 04:42:42 UTC) #1
brettw
lgtm
6 years, 6 months ago (2014-06-21 05:36:34 UTC) #2
tfarina
6 years, 6 months ago (2014-06-21 13:53:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r278973 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698