ui/base/cocoa/cocoa_base_utils_unittest.mm - Issue 345243007: Add ScopedObjCClassSwizzler in base/mac, absorbs objc_method_swizzle and ScopedClassSwizzler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/cocoa/cocoa_base_utils_unittest.mm

Issue 345243007: Add ScopedObjCClassSwizzler in base/mac, absorbs objc_method_swizzle and ScopedClassSwizzler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase to master Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/test/scoped_class_swizzler_mac.h ('K') | « base/test/scoped_class_swizzler_mac.mm ('k') | ui/events/cocoa/events_mac_unittest.mm » ('j') | ui/gfx/mac/coordinate_conversion_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/base/cocoa/cocoa_base_utils_unittest.mm

diff --git a/ui/base/cocoa/cocoa_base_utils_unittest.mm b/ui/base/cocoa/cocoa_base_utils_unittest.mm

index 5749e2d176c9518e542a6a8d2e340b260ed08d2d..f0fb48656a8920c7bcab7e073ed2f74e2fd96b06 100644

--- a/ui/base/cocoa/cocoa_base_utils_unittest.mm

+++ b/ui/base/cocoa/cocoa_base_utils_unittest.mm

@@ -6,6 +6,7 @@

#import <objc/objc-class.h>

+#import "base/test/scoped_class_swizzler_mac.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "testing/platform_test.h"

#include "ui/events/event_constants.h"

@@ -39,8 +40,8 @@ TEST_F(CocoaBaseUtilsTest, WindowOpenDispositionFromNSEvent) {

// Shift+Middle Click = new foreground tab.

{

- ScopedClassSwizzler swizzler([NSEvent class], [TestEvent class],

- @selector(modifierFlags));

+ base::ScopedClassSwizzler swizzler([NSEvent class], [TestEvent class],

+ @selector(modifierFlags));

me = cocoa_test_event_utils::MouseEventWithType(NSOtherMouseUp,

NSShiftKeyMask);

EXPECT_EQ(NEW_FOREGROUND_TAB, WindowOpenDispositionFromNSEvent(me));