editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/VariableResolverVisitor.java - Issue 34523011: Issue 13807. Support for type promotion rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/VariableResolverVisitor.java

Issue 34523011: Issue 13807. Support for type promotion rules. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updates after review comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypePromotionManager.java ('k') | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/VariableResolverVisitor.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/VariableResolverVisitor.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/VariableResolverVisitor.java

index 55abf2a1976151fb97aa7e0452fbb45b8456bf30..149aa7a430510d453aa81ac805bf97e2dc2853b4 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/VariableResolverVisitor.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/VariableResolverVisitor.java

@@ -23,6 +23,8 @@ import com.google.dart.engine.ast.SimpleIdentifier;

import com.google.dart.engine.element.Element;

import com.google.dart.engine.element.ElementKind;

import com.google.dart.engine.element.VariableElement;

+import com.google.dart.engine.internal.element.LocalVariableElementImpl;

+import com.google.dart.engine.internal.element.ParameterElementImpl;

import com.google.dart.engine.source.Source;

/**

@@ -74,8 +76,16 @@ public class VariableResolverVisitor extends ScopedVisitor {

}

// Must be local or parameter.

ElementKind kind = element.getKind();

- if (kind == ElementKind.LOCAL_VARIABLE || kind == ElementKind.PARAMETER) {

+ if (kind == ElementKind.LOCAL_VARIABLE) {

node.setStaticElement(element);

+ if (node.inSetterContext()) {

+ ((LocalVariableElementImpl) element).markPotentiallyMutated();

+ }

+ } else if (kind == ElementKind.PARAMETER) {

+ node.setStaticElement(element);

+ if (node.inSetterContext()) {

+ ((ParameterElementImpl) element).markPotentiallyMutated();

+ }

}

return null;

}