Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: src/hydrogen.h

Issue 34523004: More Hydrogen templatization. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/hydrogen.h
diff --git a/src/hydrogen.h b/src/hydrogen.h
index e671692b3cb6f16404d3c5a408c8ac2c8fe79c65..3f5e27d93191070a9304206a5b9073bffe7a21f6 100644
--- a/src/hydrogen.h
+++ b/src/hydrogen.h
@@ -1283,6 +1283,7 @@ class HGraphBuilder {
LoadKeyedHoleMode load_mode = NEVER_RETURN_HOLE);
HLoadNamedField* BuildLoadNamedField(HValue* object, HObjectAccess access);
+ HInstruction* AddLoadNamedField(HValue* object, HObjectAccess access);
HInstruction* BuildLoadStringLength(HValue* object, HValue* checked_value);
HStoreNamedField* AddStoreMapConstant(HValue* object, Handle<Map>);
HLoadNamedField* AddLoadElements(HValue* object);
@@ -1948,23 +1949,28 @@ class HOptimizedGraphBuilder : public HGraphBuilder, public AstVisitor {
env->Bind(index, value);
if (IsEligibleForEnvironmentLivenessAnalysis(var, index, value, env)) {
HEnvironmentMarker* bind =
- New<HEnvironmentMarker>(HEnvironmentMarker::BIND, index);
- AddInstruction(bind);
+ Add<HEnvironmentMarker>(HEnvironmentMarker::BIND, index);
#ifdef DEBUG
bind->set_closure(env->closure());
+#else
+ // "use" bind to make the compiler happy.
Benedikt Meurer 2013/10/22 08:38:57 We have a USE macro for this.
Igor Sheludko 2013/10/22 10:49:17 Done.
+ (void)bind;
#endif
}
}
+
HValue* LookupAndMakeLive(Variable* var) {
HEnvironment* env = environment();
int index = env->IndexFor(var);
HValue* value = env->Lookup(index);
if (IsEligibleForEnvironmentLivenessAnalysis(var, index, value, env)) {
HEnvironmentMarker* lookup =
- New<HEnvironmentMarker>(HEnvironmentMarker::LOOKUP, index);
- AddInstruction(lookup);
+ Add<HEnvironmentMarker>(HEnvironmentMarker::LOOKUP, index);
#ifdef DEBUG
lookup->set_closure(env->closure());
+#else
+ // "use" lookup to make the compiler happy.
Benedikt Meurer 2013/10/22 08:38:57 Same as above.
Igor Sheludko 2013/10/22 10:49:17 Done.
+ (void)lookup;
#endif
}
return value;

Powered by Google App Engine
This is Rietveld 408576698