More Hydrogen templatization.

More Hydrogen templatization.

Factories added to a set of Hydrogen classes.
Several old-style HXxx::New() replaced with New<HXxx>() and NewUncasted<HXxx>.
Several AddInstruction() calls following New::XXX() replaced with Add<XXX>().
AddLoadNamedField() method added to GraphBuilder.

R=bmeurer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=17318

[Benedikt Meurer, 2013-10-22 08:38:56]

First round of comments.

https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):

https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.c...
src/code-stubs-hydrogen.cc:690: HInstruction* argument =
Add<HAccessArgumentsAt>(elements, constant_one,
Fix indentation to have all arguments on next line.

https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.c...
src/code-stubs-hydrogen.cc:739: HInstruction* argument =
Add<HAccessArgumentsAt>(argument_elements,
Funky indentation, put all arguments on next line.

https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.c...
src/code-stubs-hydrogen.cc:1169: HValue* keyed_minus = AddUncasted<HSub>(key,
Funky indentation again.

https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.c...
src/code-stubs-hydrogen.cc:1179: HValue* keyed_plus =
AddUncasted<HAdd>(keyed_minus,
Funky indentation again.

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc#newcode5502
src/hydrogen.cc:5502: HInstruction* HGraphBuilder::AddLoadNamedField(HValue*
object,
Can we get rid of this AddLoadNamedField and BuildLoadNamedField functions, and
put the logic from BuildLoadNamedField into a specialized
NewUncasted<LoadNamedField> template?

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc#newcode6826
src/hydrogen.cc:6826: HInstruction* sqrt =
AddUncasted<HUnaryMathOperation>(left,
Funky indentation. Please put arguments on next line.

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc#newcode7104
src/hydrogen.cc:7104: call =
PreProcessCall(New<HCallKnownGlobal>(expr->target(),
Indentation, please put arguments on next line.

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc#newcode8838
src/hydrogen.cc:8838: HAccessArgumentsAt* result =
New<HAccessArgumentsAt>(elements, length,
Indentation, please put arguments on next line.

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.h#newcode1956
src/hydrogen.h:1956: // "use" bind to make the compiler happy.
We have a USE macro for this.

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.h#newcode1972
src/hydrogen.h:1972: // "use" lookup to make the compiler happy.
Same as above.

[Igor Sheludko, 2013-10-22 10:49:17]

https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):

https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.c...
src/code-stubs-hydrogen.cc:690: HInstruction* argument =
Add<HAccessArgumentsAt>(elements, constant_one,
On 2013/10/22 08:38:57, Benedikt Meurer wrote:
> Fix indentation to have all arguments on next line.

Done.

https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.c...
src/code-stubs-hydrogen.cc:739: HInstruction* argument =
Add<HAccessArgumentsAt>(argument_elements,
On 2013/10/22 08:38:57, Benedikt Meurer wrote:
> Funky indentation, put all arguments on next line.

Done.

https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.c...
src/code-stubs-hydrogen.cc:1169: HValue* keyed_minus = AddUncasted<HSub>(key,
On 2013/10/22 08:38:57, Benedikt Meurer wrote:
> Funky indentation again.

Done.

https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.c...
src/code-stubs-hydrogen.cc:1179: HValue* keyed_plus =
AddUncasted<HAdd>(keyed_minus,
On 2013/10/22 08:38:57, Benedikt Meurer wrote:
> Funky indentation again.

Done.

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc#newcode5502
src/hydrogen.cc:5502: HInstruction* HGraphBuilder::AddLoadNamedField(HValue*
object,
On 2013/10/22 08:38:57, Benedikt Meurer wrote:
> Can we get rid of this AddLoadNamedField and BuildLoadNamedField functions,
and
> put the logic from BuildLoadNamedField into a specialized
> NewUncasted<LoadNamedField> template?

I'm going to address this note in next commit.

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc#newcode6826
src/hydrogen.cc:6826: HInstruction* sqrt =
AddUncasted<HUnaryMathOperation>(left,
On 2013/10/22 08:38:57, Benedikt Meurer wrote:
> Funky indentation. Please put arguments on next line.

Done.

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc#newcode7104
src/hydrogen.cc:7104: call =
PreProcessCall(New<HCallKnownGlobal>(expr->target(),
On 2013/10/22 08:38:57, Benedikt Meurer wrote:
> Indentation, please put arguments on next line.

Done.

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc#newcode8838
src/hydrogen.cc:8838: HAccessArgumentsAt* result =
New<HAccessArgumentsAt>(elements, length,
On 2013/10/22 08:38:57, Benedikt Meurer wrote:
> Indentation, please put arguments on next line.

Done.

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.h#newcode1956
src/hydrogen.h:1956: // "use" bind to make the compiler happy.
On 2013/10/22 08:38:57, Benedikt Meurer wrote:
> We have a USE macro for this.

Done.

https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.h#newcode1972
src/hydrogen.h:1972: // "use" lookup to make the compiler happy.
On 2013/10/22 08:38:57, Benedikt Meurer wrote:
> Same as above.

Done.

[Benedikt Meurer, 2013-10-22 10:59:51]

LGTM

[Igor Sheludko, 2013-10-22 11:29:13]

Committed patchset #4 manually as r17318 (presubmit successful).