Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3298)

Unified Diff: chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

Issue 34523003: settings: Make DeviceOAuth2TokenServiceFactory::Get() async (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
diff --git a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
index 7ee648e6f01c8e4e663b42398be7572031b26106..c7a539c06847582c4afd946c7e7c294f93faa5ff 100644
--- a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
+++ b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
@@ -58,6 +58,11 @@ void CopyLockResult(base::RunLoop* loop,
loop->Quit();
}
+void CopyTokenService(chromeos::DeviceOAuth2TokenService** out_token_service,
+ chromeos::DeviceOAuth2TokenService* in_token_service) {
+ *out_token_service = in_token_service;
+}
+
class DeviceCloudPolicyManagerChromeOSTest
: public chromeos::DeviceSettingsTestBase {
protected:
@@ -384,8 +389,11 @@ class DeviceCloudPolicyManagerChromeOSEnrollmentTest
if (done_)
return;
- chromeos::DeviceOAuth2TokenService* token_service =
- chromeos::DeviceOAuth2TokenServiceFactory::Get();
+ chromeos::DeviceOAuth2TokenService* token_service = NULL;
+ chromeos::DeviceOAuth2TokenServiceFactory::Get(
+ base::Bind(&CopyTokenService, &token_service));
+ base::RunLoop().RunUntilIdle();
hashimoto 2013/10/22 08:49:51 nit: How about having ASSERT_TRUE(token_service) h
satorux1 2013/10/22 09:56:43 good idea. will do.
satorux1 2013/10/23 06:35:44 Done.
+
// Process robot refresh token store.
EXPECT_EQ(
"refreshToken4Test",

Powered by Google App Engine
This is Rietveld 408576698