Issue 34523002: [Sheriff] Revert "Record allocation stack traces" and "Temporarily disable test-heap-profiler/Track…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 34523002: [Sheriff] Revert "Record allocation stack traces" and "Temporarily disable test-heap-profiler/Track… (Closed)

Created:
7 years, 2 months ago by Benedikt Meurer

Modified:
7 years, 2 months ago

Reviewers:
yurys

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

[Sheriff] Revert "Record allocation stack traces" and "Temporarily disable test-heap-profiler/TrackHeapAllocations". This reverts commit r17301 and r17303 for breaking the nosnap builds. TBR=yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17307

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -690 lines)			Patch
D	src/allocation-tracker.h	View	1 chunk	+0 lines, -138 lines	0 comments	Download
D	src/allocation-tracker.cc	View	1 chunk	+0 lines, -271 lines	0 comments	Download
M	src/heap-snapshot-generator.h	View	6 chunks	+3 lines, -10 lines	0 comments	Download
M	src/heap-snapshot-generator.cc	View	9 chunks	+2 lines, -160 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	3 chunks	+0 lines, -105 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Benedikt Meurer

Committed patchset #1 manually as r17307 (presubmit successful).

7 years, 2 months ago (2013-10-22 06:56:27 UTC) #1

Message was sent while issue was closed.

Thanks and sorry for inconvenience.