Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 345223006: Make CLD data source default value actually overridable. (Closed)

Created:
6 years, 6 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 6 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Make CLD data source default value actually overridable. Silly oversight in initial checkin, this makes the default value overridable so that other distributions can override it if they wish without having to change common.gypi. BUG=367239 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279963

Patch Set 1 #

Patch Set 2 : Merge conflict with earlier patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 6 months ago (2014-06-26 06:31:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/345223006/1
6 years, 6 months ago (2014-06-26 06:32:36 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-26 06:45:29 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 06:50:54 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/76498) ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/25052) linux_chromium_chromeos_clang_dbg ...
6 years, 6 months ago (2014-06-26 06:50:55 UTC) #5
Takashi Toyoshima
lgtm. you may want to write NOTRY=TRUE line in your change description.
6 years, 6 months ago (2014-06-26 07:23:52 UTC) #6
Takashi Toyoshima
ah, but you should rebase the Patch Set 1 to apply the diff.
6 years, 6 months ago (2014-06-26 07:26:07 UTC) #7
Andrew Hayden (chromium.org)
On 2014/06/26 07:26:07, Takashi Toyoshima (chromium) wrote: > ah, but you should rebase the Patch ...
6 years, 6 months ago (2014-06-26 08:32:20 UTC) #8
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 6 months ago (2014-06-26 08:32:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/345223006/20001
6 years, 6 months ago (2014-06-26 08:33:49 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 08:35:05 UTC) #11
Message was sent while issue was closed.
Change committed as 279963

Powered by Google App Engine
This is Rietveld 408576698