Ensure all members of OriginChipInfo/OriginChipView get initialized.

Ensure all members of OriginChipInfo/OriginChipView get initialized.

BUG=382921
TEST=none
TBR=gbillock

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278845

[Peter Kasting, 2014-06-20 22:38:33]

Actually I'm just going to TBR this, this is trivial

[Peter Kasting, 2014-06-20 22:40:57]

Committed patchset #3 manually as r278845 (presubmit successful).

[jamesr, 2014-06-20 23:12:03]

This makes the browser crash on startup:

#0  0x000055555797e5ba in OriginChipView::SetBorderImages (this=0x857fa8ecda0,
images=0x555559dfbe40 <(anonymous namespace)::kNormalImages>)
    at ../../chrome/browser/ui/views/location_bar/origin_chip_view.cc:336
#1  0x000055555797e4da in OriginChipView::OriginChipView (this=0x857fa8ecda0,
location_bar_view=0x857fb5f1a20, profile=0x857fae1ef20, font_list=...)
    at ../../chrome/browser/ui/views/location_bar/origin_chip_view.cc:181
#2  0x000055555796440b in LocationBarView::Init (this=0x857fb5f1a20) at
../../chrome/browser/ui/views/location_bar/location_bar_view.cc:329
#3  0x0000555557a08ddb in ToolbarView::Init (this=0x857fb122f20) at
../../chrome/browser/ui/views/toolbar/toolbar_view.cc:263
#4  0x0000555557938672 in BrowserView::InitViews (this=0x857faafada0) at
../../chrome/browser/ui/views/frame/browser_view.cc:1951
#5  0x0000555557938053 in BrowserView::ViewHierarchyChanged (this=0x857faafada0,
details=...) at ../../chrome/browser/ui/views/frame/browser_view.cc:1809
#6  0x00005555579388ef in non-virtual thunk to
BrowserView::ViewHierarchyChanged(views::View::ViewHierarchyChangedDetails
const&) ()
    at ../../chrome/browser/ui/views/frame/browser_view.cc:1812
#7  0x00007ffff1047e67 in views::View::ViewHierarchyChangedImpl
(this=0x857faafade0, register_accelerators=true, details=...) at
../../ui/views/view.cc:1943
#8  0x00007ffff1047ef0 in views::View::PropagateAddNotifications
(this=0x857faafade0, details=...) at ../../ui/views/view.cc:1905
#9  0x00007ffff1046f8a in views::View::AddChildViewAt (this=0x857fade1ba0,
view=0x857faafade0, index=1) at ../../ui/views/view.cc:202
#10 0x00007ffff10e64cf in views::NonClientView::ViewHierarchyChanged
(this=0x857fade1ba0, details=...) at
../../ui/views/window/non_client_view.cc:174
#11 0x00007ffff1047e67 in views::View::ViewHierarchyChangedImpl
(this=0x857fade1ba0, register_accelerators=true, details=...) at
../../ui/views/view.cc:1943
#12 0x00007ffff1047ef0 in views::View::PropagateAddNotifications
(this=0x857fade1ba0, details=...) at ../../ui/views/view.cc:1905
#13 0x00007ffff1046f8a in views::View::AddChildViewAt (this=0x857fb27f8a0,
view=0x857fade1ba0, index=0) at ../../ui/views/view.cc:202
#14 0x00007ffff1046bae in views::View::AddChildView (this=0x857fb27f8a0,
view=0x857fade1ba0) at ../../ui/views/view.cc:160
#15 0x00007ffff10b4365 in views::internal::RootView::SetContentsView
(this=0x857fb27f8a0, contents_view=0x857fade1ba0) at
../../ui/views/widget/root_view.cc:192
#16 0x00007ffff10c4337 in views::Widget::SetContentsView (this=0x857fb457de0,
view=0x857fade1ba0) at ../../ui/views/widget/widget.cc:474
#17 0x00007ffff10c3ba5 in views::Widget::Init (this=0x857fb457de0,
in_params=...) at ../../ui/views/widget/widget.cc:366
#18 0x0000555557cbe73a in BrowserFrame::InitBrowserFrame (this=0x857fb457de0) at
../../chrome/browser/ui/views/frame/browser_frame.cc:144
#19 0x0000555557939407 in BrowserWindow::CreateBrowserWindow
(browser=0x857fb27f1a0) at
../../chrome/browser/ui/views/frame/browser_view.cc:2356
#20 0x0000555557815015 in (anonymous namespace)::CreateBrowserWindow
(browser=0x857fb27f1a0) at ../../chrome/browser/ui/browser.cc:234
#21 0x0000555557814b8a in Browser::Browser (this=0x857fb27f1a0, params=...) at
../../chrome/browser/ui/browser.cc:417
#22 0x00005555578aeae8 in StartupBrowserCreatorImpl::OpenTabsInBrowser
(this=0x7fffffffb980, browser=0x0, process_startup=true,
tabs=std::__debug::vector of length 1, capacity 1 = {...}, 
    desktop_type=chrome::HOST_DESKTOP_TYPE_FIRST) at
../../chrome/browser/ui/startup/startup_browser_creator_impl.cc:773
#23 0x00005555578adbfa in StartupBrowserCreatorImpl::ProcessSpecifiedURLs
(this=0x7fffffffb980, urls_to_open=std::__debug::vector of length 0, capacity 0,

    desktop_type=chrome::HOST_DESKTOP_TYPE_FIRST) at
../../chrome/browser/ui/startup/startup_browser_creator_impl.cc:725
#24 0x00005555578ad801 in StartupBrowserCreatorImpl::ProcessStartupURLs
(this=0x7fffffffb980, urls_to_open=std::__debug::vector of length 0, capacity 0,

    desktop_type=chrome::HOST_DESKTOP_TYPE_FIRST) at
../../chrome/browser/ui/startup/startup_browser_creator_impl.cc:665
#25 0x00005555578aca4c in StartupBrowserCreatorImpl::ProcessLaunchURLs
(this=0x7fffffffb980, process_startup=true, urls_to_open=std::__debug::vector of
length 0, capacity 0, 
    desktop_type=chrome::HOST_DESKTOP_TYPE_FIRST) at
../../chrome/browser/ui/startup/startup_browser_creator_impl.cc:550
#26 0x00005555578ac20e in StartupBrowserCreatorImpl::Launch
(this=0x7fffffffb980, profile=0x857fae1ef20, urls_to_open=std::__debug::vector
of length 0, capacity 0, process_startup=true, 
    desktop_type=chrome::HOST_DESKTOP_TYPE_FIRST) at
../../chrome/browser/ui/startup/startup_browser_creator_impl.cc:381
#27 0x00005555578a5861 in StartupBrowserCreator::LaunchBrowser
(this=0x857fac8c7a0, command_line=..., profile=0x857fae1ef20, cur_dir=..., 
    process_startup=chrome::startup::IS_PROCESS_STARTUP,
is_first_run=chrome::startup::IS_NOT_FIRST_RUN, return_code=0x7fffffffc884)
    at ../../chrome/browser/ui/startup/startup_browser_creator.cc:315
#28 0x00005555578a72c2 in StartupBrowserCreator::ProcessCmdLineImpl
(command_line=..., cur_dir=..., process_startup=true,
last_used_profile=0x857fae1ef20, 
    last_opened_profiles=std::__debug::vector of length 1, capacity 1 = {...},
return_code=0x7fffffffc884, browser_creator=0x857fac8c7a0)
    at ../../chrome/browser/ui/startup/startup_browser_creator.cc:669
#29 0x000055555650339b in StartupBrowserCreator::Start (this=0x857fac8c7a0,
cmd_line=..., cur_dir=..., last_used_profile=0x857fae1ef20, 
    last_opened_profiles=std::__debug::vector of length 1, capacity 1 = {...},
return_code=0x7fffffffc884) at
../../chrome/browser/ui/startup/startup_browser_creator.h:48
#30 0x00005555565003fc in ChromeBrowserMainParts::PreMainMessageLoopRunImpl
(this=0x857fa82d8e0) at ../../chrome/browser/chrome_browser_main.cc:1481
#31 0x00005555564ff1e2 in ChromeBrowserMainParts::PreMainMessageLoopRun
(this=0x857fa82d8e0) at ../../chrome/browser/chrome_browser_main.cc:973
#32 0x00007fffe8275c86 in content::BrowserMainLoop::PreMainMessageLoopRun
(this=0x857fa82d7a0) at ../../content/browser/browser_main_loop.cc:691
#33 0x00007fffe827d122 in base::internal::RunnableAdapter<int
(content::BrowserMainLoop::*)()>::Run (this=0x7fffffffd010,
object=0x857fa82d7a0) at ../../base/bind_internal.h:134
#34 0x00007fffe827d09c in base::internal::InvokeHelper<false, int,
base::internal::RunnableAdapter<int (content::BrowserMainLoop::*)()>, void
(content::BrowserMainLoop*)>::MakeItSo(base::internal::RunnableAdapter<int
(content::BrowserMainLoop::*)()>, content::BrowserMainLoop*) (runnable=...,
a1=0x857fa82d7a0) at ../../base/bind_internal.h:863
#35 0x00007fffe827d06a in base::internal::Invoker<1,
base::internal::BindState<base::internal::RunnableAdapter<int
(content::BrowserMainLoop::*)()>, int (content::BrowserMainLoop*), void
(base::internal::UnretainedWrapper<content::BrowserMainLoop>)>, int
(content::BrowserMainLoop*)>::Run(base::internal::BindStateBase*)
(base=0x857fac92f20) at ../../base/bind_internal.h:1166
#36 0x00007fffe875130e in base::Callback<int ()>::Run() const
(this=0x857fac92f90) at ../../base/callback.h:401
#37 0x00007fffe8a810cb in content::StartupTaskRunner::RunAllTasksNow
(this=0x857faaaad20) at ../../content/browser/startup_task_runner.cc:45
#38 0x00007fffe8274110 in content::BrowserMainLoop::CreateStartupTasks
(this=0x857fa82d7a0) at ../../content/browser/browser_main_loop.cc:594
#39 0x00007fffe8280112 in content::BrowserMainRunnerImpl::Initialize
(this=0x857fa7c7da0, parameters=...) at
../../content/browser/browser_main_runner.cc:106
#40 0x00007fffe82705a5 in content::BrowserMain (parameters=...) at
../../content/browser/browser_main.cc:22
#41 0x00007fffe81f0eaf in content::RunNamedProcessTypeMain (process_type="",
main_function_params=..., delegate=0x7fffffffd9e0) at
../../content/app/content_main_runner.cc:416
#42 0x00007fffe81f5008 in content::ContentMainRunnerImpl::Run
(this=0x857fa7ea6e0) at ../../content/app/content_main_runner.cc:762
#43 0x00007fffe81f0415 in content::ContentMain (params=...) at
../../content/app/content_main.cc:19
#44 0x0000555555a88d55 in ChromeMain (argc=1, argv=0x7fffffffdb38) at
../../chrome/app/chrome_main.cc:46
#45 0x0000555555a88d02 in main (argc=1, argv=0x7fffffffdb38) at
../../chrome/app/chrome_exe_main_aura.cc:17

[jamesr, 2014-06-20 23:19:41]

Specifically GetThemeProvider() is null