Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 345183003: optimize circularclips to act as a bench, fix null-check bug in etcbench (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 6 months ago
Reviewers:
krajcevski, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

optimize circularclips to act as a bench, fix null-check bug in etcbench BUG=skia: Committed: https://skia.googlesource.com/skia/+/bbf3e8982d9e6846196f73068bb83db849654f12

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M bench/ETCBitmapBench.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M gm/circularclips.cpp View 2 chunks +21 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
reed1
6 years, 6 months ago (2014-06-20 17:56:06 UTC) #1
krajcevski
On 2014/06/20 17:56:06, reed1 wrote: lgtm
6 years, 6 months ago (2014-06-20 17:57:46 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-20 17:58:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/345183003/20001
6 years, 6 months ago (2014-06-20 17:59:01 UTC) #4
rmistry
The CQ bit was unchecked by rmistry@google.com
6 years, 6 months ago (2014-06-20 18:23:30 UTC) #5
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 6 months ago (2014-06-20 18:24:25 UTC) #6
rmistry
The CQ bit was unchecked by rmistry@google.com
6 years, 6 months ago (2014-06-20 18:27:47 UTC) #7
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 6 months ago (2014-06-20 18:29:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/345183003/20001
6 years, 6 months ago (2014-06-20 18:30:17 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 18:34:03 UTC) #10
Message was sent while issue was closed.
Change committed as bbf3e8982d9e6846196f73068bb83db849654f12

Powered by Google App Engine
This is Rietveld 408576698