Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 345173002: Fix duplicate include, ordering, and whitespace style in chrome_tests.gypi (Closed)

Created:
6 years, 6 months ago by Chris Thompson
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix duplicate include, ordering, and whitespace style in chrome_tests.gypi From https://codereview.chromium.org/300873002. Cleanup/style fix so no bug created. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280503

Patch Set 1 #

Patch Set 2 : Rebase-update #

Total comments: 1

Patch Set 3 : Remove bad includes in gypi from old merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/chrome_tests.gypi View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Chris Thompson
sky@ could you PTAL? (Sorry I forgot that I made a CL to fix your ...
6 years, 5 months ago (2014-06-27 18:45:31 UTC) #1
sky
https://codereview.chromium.org/345173002/diff/20001/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (left): https://codereview.chromium.org/345173002/diff/20001/chrome/chrome_tests.gypi#oldcode79 chrome/chrome_tests.gypi:79: 'browser/plugins/npapi_infobar_browsertest.cc', You don't document why you're moving this from ...
6 years, 5 months ago (2014-06-27 21:57:44 UTC) #2
Chris Thompson
On 2014/06/27 21:57:44, sky wrote: > https://codereview.chromium.org/345173002/diff/20001/chrome/chrome_tests.gypi > File chrome/chrome_tests.gypi (left): > > https://codereview.chromium.org/345173002/diff/20001/chrome/chrome_tests.gypi#oldcode79 > ...
6 years, 5 months ago (2014-06-27 21:58:29 UTC) #3
sky
LGTM
6 years, 5 months ago (2014-06-27 22:22:23 UTC) #4
Chris Thompson
The CQ bit was checked by cthomp@chromium.org
6 years, 5 months ago (2014-06-27 22:22:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cthomp@chromium.org/345173002/20001
6 years, 5 months ago (2014-06-27 22:24:53 UTC) #6
Chris Thompson
The CQ bit was unchecked by cthomp@chromium.org
6 years, 5 months ago (2014-06-27 23:29:48 UTC) #7
Chris Thompson
The CQ bit was checked by cthomp@chromium.org
6 years, 5 months ago (2014-06-27 23:49:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cthomp@chromium.org/345173002/40001
6 years, 5 months ago (2014-06-27 23:51:58 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-06-28 05:53:33 UTC) #10
Message was sent while issue was closed. 
Change committed as 280503

Powered by Google App Engine
This is Rietveld 408576698