Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 345133005: Avoid changing |drag_reverted_| if the drag was already completed on ChromeOS (Closed)

Created:
6 years, 5 months ago by pkotwicz
Modified:
6 years, 5 months ago
Reviewers:
varkha, sky
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

Avoid changing |drag_reverted_| if the drag was already completed on ChromeOS This is part #2 of https://codereview.chromium.org/354343002/ BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282392

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -30 lines) Patch
M ash/wm/toplevel_window_event_handler.h View 1 2 3 2 chunks +9 lines, -3 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 2 3 4 chunks +19 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pkotwicz
Scott, can you please take a look? I mostly want your opinion on never handling ...
6 years, 5 months ago (2014-07-04 15:27:45 UTC) #1
varkha
https://codereview.chromium.org/345133005/diff/90001/ash/wm/toplevel_window_event_handler.h File ash/wm/toplevel_window_event_handler.h (right): https://codereview.chromium.org/345133005/diff/90001/ash/wm/toplevel_window_event_handler.h#newcode77 ash/wm/toplevel_window_event_handler.h:77: // completed. nit: s/"completed"/"completed or reverted" since it seems ...
6 years, 5 months ago (2014-07-08 14:48:37 UTC) #2
sky
https://codereview.chromium.org/345133005/diff/130001/ash/wm/toplevel_window_event_handler.cc File ash/wm/toplevel_window_event_handler.cc (left): https://codereview.chromium.org/345133005/diff/130001/ash/wm/toplevel_window_event_handler.cc#oldcode509 ash/wm/toplevel_window_event_handler.cc:509: event->SetHandled(); Why is marking the event has handled no ...
6 years, 5 months ago (2014-07-09 20:27:02 UTC) #3
pkotwicz
https://codereview.chromium.org/345133005/diff/130001/ash/wm/toplevel_window_event_handler.cc File ash/wm/toplevel_window_event_handler.cc (left): https://codereview.chromium.org/345133005/diff/130001/ash/wm/toplevel_window_event_handler.cc#oldcode509 ash/wm/toplevel_window_event_handler.cc:509: event->SetHandled(); I couldn't find a case where not handling ...
6 years, 5 months ago (2014-07-10 00:23:52 UTC) #4
sky
Ok, LGTM
6 years, 5 months ago (2014-07-10 16:13:36 UTC) #5
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-10 17:03:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/345133005/190001
6 years, 5 months ago (2014-07-10 17:05:11 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 19:21:08 UTC) #8
Message was sent while issue was closed.
Change committed as 282392

Powered by Google App Engine
This is Rietveld 408576698