Issue 345113004: DevTools: complete 2-sided migration to attach w/ id (content)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345113004: DevTools: complete 2-sided migration to attach w/ id (content) (Closed)

Created:
6 years, 6 months ago by pfeldman

Modified:
6 years, 6 months ago

Reviewers:
vsevik

CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: complete 2-sided migration to attach w/ id (content) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278797

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	content/renderer/devtools/devtools_agent.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	content/renderer/devtools/devtools_agent.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/345113004/20001

6 years, 6 months ago (2014-06-20 16:07:59 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...

6 years, 6 months ago (2014-06-20 19:20:33 UTC) #4

Message was sent while issue was closed.

Change committed as 278797

Expand Messages | Collapse Messages