Add the ability for gpu to render dotted lines (dashed line, 0 on interval, round caps)

Add the ability for gpu to render dotted lines (dashed line, 0 on interval, round caps)

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/f767e792b929df9a2d9f35f9c68adaa9251f4da3

[bsalomon, 2014-06-25 14:20:44]

Instead of passing bool isRoundCap can we pass an enum? Either the existing cap
enum (and assert it's a supported one) or a new enum that just has the legal
values.

https://codereview.chromium.org/345113003/diff/1/src/gpu/effects/GrDashingEff...
File src/gpu/effects/GrDashingEffect.cpp (right):

https://codereview.chromium.org/345113003/diff/1/src/gpu/effects/GrDashingEff...
src/gpu/effects/GrDashingEffect.cpp:518: // transforms all points so that we can
compare them to our test rect
test circle?

https://codereview.chromium.org/345113003/diff/1/src/gpu/effects/GrDashingEff...
src/gpu/effects/GrDashingEffect.cpp:525: // The amount of coverage removed in x
and y by the edges is computed as a pair of negative
This comment should be removed right?

[egdaniel, 2014-07-01 14:15:58]

ptal

[egdaniel, 2014-07-01 14:15:58]

ptal

[bsalomon, 2014-07-01 14:24:34]

lgtm w/ suggestions

https://codereview.chromium.org/345113003/diff/20001/src/gpu/effects/GrDashin...
File src/gpu/effects/GrDashingEffect.cpp (right):

https://codereview.chromium.org/345113003/diff/20001/src/gpu/effects/GrDashin...
src/gpu/effects/GrDashingEffect.cpp:430: SkScalar strokeWidth);
Why not just call it radius?

https://codereview.chromium.org/345113003/diff/20001/src/gpu/effects/GrDashin...
src/gpu/effects/GrDashingEffect.cpp:848: break;
Don't need the breaks when there is a return on the previous line.

[egdaniel, 2014-07-02 13:05:53]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-07-02 13:06:10]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/egdaniel@google.com/345113003/60001

[commit-bot: I haz the power, 2014-07-02 13:21:41]

Change committed as f767e792b929df9a2d9f35f9c68adaa9251f4da3