Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: runtime/bin/vmservice/client/lib/src/app/application.dart

Issue 345113002: Fix Observatory code coverage (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/app/application.dart
diff --git a/runtime/bin/vmservice/client/lib/src/app/application.dart b/runtime/bin/vmservice/client/lib/src/app/application.dart
index 3ebf280b732a42800563cf59fcccb41f21cba9c5..183d6b18a77eeb3d0d240d1a3765691699ba8282 100644
--- a/runtime/bin/vmservice/client/lib/src/app/application.dart
+++ b/runtime/bin/vmservice/client/lib/src/app/application.dart
@@ -126,10 +126,6 @@ class ObservatoryApplication extends Observable {
@reflectable ServiceObject lastErrorOrException;
- /// Any client-level arguments for viewing the current response.
- @observable String args;
- // TODO(turnidge): Make args a Map.
-
void _initOnce() {
_registerPanes();
vm.errors.stream.listen(_onError);
@@ -154,15 +150,16 @@ class ObservatoryApplication extends Observable {
void _onError(ServiceError error) {
lastErrorOrException = error;
- _visit('error/');
+ _visit('error/', null);
}
void _onException(ServiceException exception) {
lastErrorOrException = exception;
- _visit('error/');
+ _visit('error/', null);
}
- void _visit(String url) {
+ void _visit(String url, String args) {
+ // TODO(johnmccutchan): Pass [args] to pane.
for (var i = 0; i < _paneRegistry.length; i++) {
var pane = _paneRegistry[i];
if (pane.canVisit(url)) {

Powered by Google App Engine
This is Rietveld 408576698