Issue 345053003: Fix typo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345053003: Fix typo (Closed)

Created:
6 years, 6 months ago by ahe

Modified:
6 years, 6 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, Bill Hesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix typo Committed: https://code.google.com/p/dart/source/detail?r=37544

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	dart/tests/utils/utils.status	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

Committed patchset #1 manually as r37544 (presubmit successful).

6 years, 6 months ago (2014-06-20 12:41:59 UTC) #2

vsm

https://codereview.chromium.org/345053003/diff/1/dart/tests/utils/utils.status File dart/tests/utils/utils.status (right): https://codereview.chromium.org/345053003/diff/1/dart/tests/utils/utils.status#newcode24 dart/tests/utils/utils.status:24: [ $compiler == none && ( $runtime == drt ...

6 years, 6 months ago (2014-06-20 12:46:11 UTC) #3

ahe

6 years, 6 months ago (2014-06-20 12:49:12 UTC) #4

Message was sent while issue was closed.

Thank you.

https://codereview.chromium.org/345053003/diff/1/dart/tests/utils/utils.status
File dart/tests/utils/utils.status (right):

https://codereview.chromium.org/345053003/diff/1/dart/tests/utils/utils.statu...
dart/tests/utils/utils.status:24: [ $compiler == none && ( $runtime == drt  ||
$runtime == dartium ) ]
On 2014/06/20 12:46:11, vsm wrote:
> Actually, we probably need $runtime == ContentShellOnAndroid as well.  That
bot
> is hosed at the moment, but it looks like it normally runs that test.

https://codereview.chromium.org/343153002/

Expand Messages | Collapse Messages