Issue 344993002: Add cloud_devices and json_schema to GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 344993002: Add cloud_devices and json_schema to GN build. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
blundell

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add cloud_devices and json_schema to GN build. These components are needed by chrome/common. This also adds a "components" meta-target to avoid listing all components in the root build file. TBR=blundell Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278608

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -28 lines)			Patch
M	BUILD.gn	View	1 2 3	3 chunks	+0 lines, -25 lines	2 comments	Download
A	components/BUILD.gn	View	1 2 3	1 chunk	+46 lines, -0 lines	0 comments	Download
A	components/cloud_devices/common/BUILD.gn	View		1 chunk	+25 lines, -0 lines	0 comments	Download
A +	components/json_schema/BUILD.gn	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

Committed patchset #4 manually as r278608 (presubmit successful).

6 years, 6 months ago (2014-06-20 05:13:27 UTC) #2

blundell

https://codereview.chromium.org/344993002/diff/80001/BUILD.gn File BUILD.gn (left): https://codereview.chromium.org/344993002/diff/80001/BUILD.gn#oldcode25 BUILD.gn:25: "//components/favicon_base", Should the components group be referenced in this ...

6 years, 6 months ago (2014-06-20 17:38:42 UTC) #3

brettw

6 years, 6 months ago (2014-06-20 19:31:17 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/344993002/diff/80001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/344993002/diff/80001/BUILD.gn#oldcode25
BUILD.gn:25: "//components/favicon_base",
On 2014/06/20 17:38:42, blundell wrote:
> Should the components group be referenced in this top-level file?

Oops, that was in an earlier patch but got removed when I did some merges. Will
fix in a followup. Thanks!

Expand Messages | Collapse Messages