Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 344963003: Revert of Flag covering Rollback removed. (Closed)

Created:
6 years, 6 months ago by Nikita (slow)
Modified:
6 years, 6 months ago
Reviewers:
merkulova
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Revert of Flag covering Rollback removed. (https://codereview.chromium.org/326373002/) Reason for revert: This feature is postponed to M38. Original issue's description: > Flag covering Rollback removed. > > BUG=368860 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277725 TBR=merkulova@chromium.org NOTREECHECKS=true NOTRY=true BUG=368860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -36 lines) Patch
M chrome/browser/chromeos/login/reset_browsertest.cc View 4 chunks +42 lines, -30 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 3 chunks +35 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.h View 2 chunks +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nikita (slow)
Created Revert of Flag covering Rollback removed.
6 years, 6 months ago (2014-06-23 16:27:02 UTC) #1
Nikita (slow)
On 2014/06/23 16:27:02, Nikita Kostylev wrote: > Created Revert of Flag covering Rollback removed. See ...
6 years, 6 months ago (2014-06-23 16:27:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/344963003/1
6 years, 6 months ago (2014-06-23 16:27:42 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 16:28:44 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chromeos/chromeos_switches.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-23 16:28:45 UTC) #5
Nikita (slow)
6 years, 6 months ago (2014-06-24 08:01:54 UTC) #6
I'll do a proper revert on branch instead.

Powered by Google App Engine
This is Rietveld 408576698