Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 344943002: Security interstitial tweaks (Closed)

Created:
6 years, 6 months ago by felt
Modified:
6 years, 6 months ago
Reviewers:
Dan Beam, mattm
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Security interstitial tweaks Designers asked for some final tweaks to polish the interstitials. Small changes to CSS and strings. BUG=381260 passed all of the bots at least once but cq is dead dead dead: NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278787

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/ssl/interstitial_v2.css View 1 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
felt
hi dan, matt, small CL with a few tiny changes, per designer request. PTAL. thx. ...
6 years, 6 months ago (2014-06-19 18:53:54 UTC) #1
mattm
Same bug number is listed twice. lgtm
6 years, 6 months ago (2014-06-19 22:37:39 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/344943002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/344943002/diff/1/chrome/app/generated_resources.grd#newcode9246 chrome/app/generated_resources.grd:9246: + Attackers currently on <ph name="BEGIN_BOLD">&lt;strong&gt;</ph><ph name="SITE">$1<ex>example.com</ex></ph><ph name="END_BOLD">&lt;/strong&gt;</ph> ...
6 years, 6 months ago (2014-06-20 02:48:48 UTC) #3
felt
https://codereview.chromium.org/344943002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/344943002/diff/1/chrome/app/generated_resources.grd#newcode9246 chrome/app/generated_resources.grd:9246: + Attackers currently on <ph name="BEGIN_BOLD">&lt;strong&gt;</ph><ph name="SITE">$1<ex>example.com</ex></ph><ph name="END_BOLD">&lt;/strong&gt;</ph> might ...
6 years, 6 months ago (2014-06-20 03:14:09 UTC) #4
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-20 03:14:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/344943002/1
6 years, 6 months ago (2014-06-20 03:18:03 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 07:54:12 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 07:59:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/85860)
6 years, 6 months ago (2014-06-20 07:59:41 UTC) #9
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-20 14:44:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/344943002/20001
6 years, 6 months ago (2014-06-20 14:47:21 UTC) #11
felt
The CQ bit was unchecked by felt@chromium.org
6 years, 6 months ago (2014-06-20 18:42:52 UTC) #12
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-20 18:42:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/344943002/20001
6 years, 6 months ago (2014-06-20 19:03:51 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 19:08:02 UTC) #15
Message was sent while issue was closed.
Change committed as 278787

Powered by Google App Engine
This is Rietveld 408576698