Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 344883007: SVG: Move/rename reference management to SVGElement (Closed)

Created:
6 years, 6 months ago by kouhei (in TOK)
Modified:
6 years, 6 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, shans, eae+blinkwatch, Steve Block, rwlbuis, kouhei+svg_chromium.org, dstockwell, Timothy Loh, jchaffraix+rendering, rune+blink, Eric Willigers, rjwright, zoltan1, krit, gyuyoung.kim_webkit.org, darktears, blink-reviews-rendering, blink-reviews-animation_chromium.org, leviw+renderwatch, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Project:
blink
Visibility:
Public.

Description

SVG: Move/rename reference management to SVGElement No change in logic, but rename and move. I used different naming convensions based on suggestions by fs@opera.com : "referencingElements" is renamed "outgoingReferences", and "referencedElements" is renamed "incomingReferences". - |SVGDocumentExtensions::setOfElementsReferencingTarget| moved to |SVGElement::setOfIncomingReferences| - |SVGDocumentExtensions::addElementReferencingTarget| moved to |SVGElement::addOutgoingReferenceTo| - |SVGDocumentExtensions::removeAllTargetReferencesForElement| moved to |SVGElement::removeAllOutgoingReferences| - |SVGDocumentExtensions::rebuildAllElementReferencesForTarget| moved to |SVGElement::rebuildAllIncomingReferences| - |SVGDocumentExtensions::removeAllElementReferencesForTarget| moved to |SVGElement::removeAllIncomingReferences| Changes to files SVG\w+Element.cpp made by a sed script: s/document()\.accessSVGExtensions()\.addElementReferencingTarget(this, \([a-Z()\*]\+\))/addOutgoingReferenceTo(\1)/g s/document()\.accessSVGExtensions()\.removeAllTargetReferencesForElement(this)/removeAllOutgoingReferences()/g s/document()\.accessSVGExtensions()\.setOfElementsReferencingTarget(this)/setOfIncomingReferences()/g BUG=378670 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177039

Patch Set 1 #

Patch Set 2 : make changes by sed #

Patch Set 3 : renamed to addReferenceTo #

Patch Set 4 : remove sed script from CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -106 lines) Patch
M Source/core/rendering/svg/RenderSVGResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGDocumentExtensions.h View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 1 2 1 chunk +0 lines, -69 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 2 3 chunks +9 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 2 4 chunks +69 lines, -5 lines 0 comments Download
M Source/core/svg/SVGElementRareData.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGElementRareData.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEImageElement.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMPathElement.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kouhei (in TOK)
Refactoring renaming/moving methods to SVGElement. Please take a look when you have time. The names ...
6 years, 6 months ago (2014-06-25 08:40:15 UTC) #1
fs
On 2014/06/25 08:40:15, kouhei wrote: > Refactoring renaming/moving methods to SVGElement. Please take a look ...
6 years, 6 months ago (2014-06-25 10:59:54 UTC) #2
pdr.
On 2014/06/25 10:59:54, fs wrote: > On 2014/06/25 08:40:15, kouhei wrote: > > Refactoring renaming/moving ...
6 years, 6 months ago (2014-06-25 16:02:44 UTC) #3
kouhei (in TOK)
Thanks for review! renamed to addReferenceTo
6 years, 6 months ago (2014-06-26 23:24:12 UTC) #4
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 6 months ago (2014-06-26 23:25:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/344883007/60001
6 years, 6 months ago (2014-06-26 23:26:08 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 01:45:33 UTC) #7
Message was sent while issue was closed.
Change committed as 177039

Powered by Google App Engine
This is Rietveld 408576698