chrome/browser/about_flags.h - Issue 344883002: Collect UMA statistics on which chrome://flags lead to chrome restart on ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.h

Issue 344883002: Collect UMA statistics on which chrome://flags lead to chrome restart on ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bug in about_flags.cc. Sdded comments. s/restarting/custom/ Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/about_flags.h

diff --git a/chrome/browser/about_flags.h b/chrome/browser/about_flags.h

index 55859db985106a932db1ab706f74d13f416c2512..926c1f373ec341744b782b19c6d1d3a1594fdd94 100644

--- a/chrome/browser/about_flags.h

+++ b/chrome/browser/about_flags.h

@@ -6,6 +6,7 @@

#define CHROME_BROWSER_ABOUT_FLAGS_H_

#include <map>

+#include <set>

#include <string>

#include "base/command_line.h"

@@ -117,9 +118,12 @@ void ConvertFlagsToSwitches(FlagsStorage* flags_storage,

// Compares a set of switches of the two provided command line objects and

// returns true if they are the same and false otherwise.

+// If |out_difference| is not NULL, it's filled with set_symmetric_difference

+// between sets.

bool AreSwitchesIdenticalToCurrentCommandLine(

const base::CommandLine& new_cmdline,

- const base::CommandLine& active_cmdline);

+ const base::CommandLine& active_cmdline,

+ std::set<CommandLine::StringType>* out_difference);

sky 2014/06/19 20:23:28 Add test coverage that out_difference is correctly

Alexander Alekseev 2014/06/24 21:51:52 Done.

// Differentiate between generic flags available on a per session base and flags

// that influence the whole machine and can be said by the admin only. This flag

« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | chrome/browser/about_flags.cc » ('J')