Issue 344873006: Add widevine and extensions resources to GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 344873006: Add widevine and extensions resources to GN build. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Add widevine and extensions resources to GN build. Fix up some references in content and webkit for targets that now exist. TBR=hclam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278616

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -30 lines)			Patch
M	BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/BUILD.gn	View	1 2	2 chunks	+3 lines, -7 lines	0 comments	Download
M	content/BUILD.gn	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/child/BUILD.gn	View		2 chunks	+1 line, -1 line	0 comments	Download
M	content/common/BUILD.gn	View		2 chunks	+13 lines, -13 lines	0 comments	Download
M	content/public/renderer/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/BUILD.gn	View		4 chunks	+2 lines, -3 lines	0 comments	Download
A	extensions/BUILD.gn	View	1 2	1 chunk	+25 lines, -0 lines	0 comments	Download
M	extensions/extensions_strings.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	extensions/strings/BUILD.gn	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
A	third_party/widevine/cdm/BUILD.gn	View	1 2	1 chunk	+102 lines, -0 lines	0 comments	Download
M	third_party/widevine/cdm/widevine_cdm.gyp	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	webkit/common/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/common/webkit_common.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

brettw

Committed patchset #3 manually as r278616 (presubmit successful).

6 years, 6 months ago (2014-06-20 05:27:03 UTC) #1

Message was sent while issue was closed.

lgtm