Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 344873004: Port SampleApp to SkCommandLineFlags. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Port SampleApp to SkCommandLineFlags. BUG=skia: Committed: https://skia.googlesource.com/skia/+/fd117d8829407bb9903aafa436020d00ce762ec0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -140 lines) Patch
M samplecode/SampleApp.h View 1 chunk +0 lines, -8 lines 0 comments Download
M samplecode/SampleApp.cpp View 4 chunks +45 lines, -132 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 6 months ago (2014-06-19 20:47:13 UTC) #1
bsalomon
lgtm
6 years, 6 months ago (2014-06-19 20:51:57 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-19 20:52:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/344873004/1
6 years, 6 months ago (2014-06-19 20:52:25 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 21:19:00 UTC) #5
Message was sent while issue was closed.
Change committed as fd117d8829407bb9903aafa436020d00ce762ec0

Powered by Google App Engine
This is Rietveld 408576698