Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 344873002: Remove unnecessary includes of GlyphBuffer.h. (Closed)

Created:
6 years, 6 months ago by jbroman
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, blink-reviews-rendering, Rik, jbroman, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, danakj, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Remove unnecessary includes of GlyphBuffer.h. Previously this was included in many other source files. For me, this reduces the number of affected build targets from 889 to 93. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176521

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M Source/core/rendering/InlineTextBox.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGTextMetricsBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/SimpleFontData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzFaceSkia.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/mac/ComplexTextController.h View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/platform/fonts/mac/ComplexTextController.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jbroman
Trivial. Was getting annoyed at how much stuff rebuilds whenever I change GlyphBuffer (which isn't ...
6 years, 6 months ago (2014-06-19 15:19:32 UTC) #1
eae
On 2014/06/19 15:19:32, jbroman wrote: > Trivial. Was getting annoyed at how much stuff rebuilds ...
6 years, 6 months ago (2014-06-19 16:14:21 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 6 months ago (2014-06-19 16:14:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/344873002/20001
6 years, 6 months ago (2014-06-19 16:15:03 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 16:19:01 UTC) #5
Message was sent while issue was closed.
Change committed as 176521

Powered by Google App Engine
This is Rietveld 408576698