[NaCl SDK] nacl_io: Fix bug in getaddrinfo() where service is "0"

[NaCl SDK] nacl_io: Fix bug in getaddrinfo() where service is "0"

Add a test for this case.

TEST=unit tests
BUG=386220
R=binji@chromium.org, bradnelson@google.com

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278543

[bradn, 2014-06-19 19:38:38]

lgtm with question

https://codereview.chromium.org/344833005/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/host_resolver.cc (right):

https://codereview.chromium.org/344833005/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/host_resolver.cc:355: canon_name =
strdup(node);
While you're in here. When I was trying to figure out what was going on, I
noticed that canon_name is thee only thing used past this point (ie node is
not).
Did you mean for this to be outside the
if (hints->ai_flags & AI_CANONNAME) {
?
Otherwise I'm not clear on how the CreateAddrInfo below works when AI_CANONNAME
is off.

[Sam Clegg, 2014-06-19 19:59:56]

https://codereview.chromium.org/344833005/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/host_resolver.cc (right):

https://codereview.chromium.org/344833005/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/host_resolver.cc:355: canon_name =
strdup(node);
On 2014/06/19 19:38:38, bradn wrote:
> While you're in here. When I was trying to figure out what was going on, I
> noticed that canon_name is thee only thing used past this point (ie node is
> not).
> Did you mean for this to be outside the
> if (hints->ai_flags & AI_CANONNAME) {
> ?
> Otherwise I'm not clear on how the CreateAddrInfo below works when
AI_CANONNAME
> is off.

If AI_CANONNAME is off then I think canon_name is supposed to be NULL in the
results.

[binji, 2014-06-19 20:00:32]

lgtm

https://codereview.chromium.org/344833005/diff/1/native_client_sdk/src/tests/...
File native_client_sdk/src/tests/nacl_io_test/host_resolver_test.cc (right):

https://codereview.chromium.org/344833005/diff/1/native_client_sdk/src/tests/...
native_client_sdk/src/tests/nacl_io_test/host_resolver_test.cc:115: // Numberic
only
Numeric

https://codereview.chromium.org/344833005/diff/1/native_client_sdk/src/tests/...
native_client_sdk/src/tests/nacl_io_test/host_resolver_test.cc:124:
ASSERT_EQ(htons(0), in->sin_port);
only testing the port? If so, maybe change the test name.

[Sam Clegg, 2014-06-19 22:37:48]

https://codereview.chromium.org/344833005/diff/1/native_client_sdk/src/tests/...
File native_client_sdk/src/tests/nacl_io_test/host_resolver_test.cc (right):

https://codereview.chromium.org/344833005/diff/1/native_client_sdk/src/tests/...
native_client_sdk/src/tests/nacl_io_test/host_resolver_test.cc:124:
ASSERT_EQ(htons(0), in->sin_port);
On 2014/06/19 20:00:32, binji wrote:
> only testing the port? If so, maybe change the test name.

Done.. although the "Service" is really the port (IIUC).

[binji, 2014-06-19 22:52:29]

https://codereview.chromium.org/344833005/diff/1/native_client_sdk/src/tests/...
File native_client_sdk/src/tests/nacl_io_test/host_resolver_test.cc (right):

https://codereview.chromium.org/344833005/diff/1/native_client_sdk/src/tests/...
native_client_sdk/src/tests/nacl_io_test/host_resolver_test.cc:124:
ASSERT_EQ(htons(0), in->sin_port);
On 2014/06/19 22:37:48, Sam Clegg wrote:
> On 2014/06/19 20:00:32, binji wrote:
> > only testing the port? If so, maybe change the test name.
> 
> Done.. although the "Service" is really the port (IIUC).

Sorry, I was confused. I've never heard a port called a service before, and I
didn't see any reference to service anywhere else.

[Sam Clegg, 2014-06-20 00:13:51]

Committed patchset #4 manually as r278543 (presubmit successful).