Include Document.h in fewer headers

Include Document.h in fewer headers

Since Document.h is included in so many different places this does not
amount to much recompilation savings (1165 -> 1155), but does put the
include where it belongs for future reduction patches.

R=haraken@chromium.org, jochen@chromium.org, morrita@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176831

[philipj_slow, 2014-06-20 17:41:51]

Note that the only reason that Document.h is included in StyleResolver.h is
Settings* documentSettings() { return m_document.settings(); }, which is only
used in ASSERTs and trivial to get rid of. I mean to do that in a following
patch to push Document.h out of StyleResolver.h and into RenderObject.h, which
is where the real challenge of header separation lies. (Solving that reduces
recompilation by a lot, when I tried it hackishly.)

[philipj_slow, 2014-06-20 20:58:29]

On 2014/06/20 17:41:51, philipj wrote:
> Note that the only reason that Document.h is included in StyleResolver.h is
> Settings* documentSettings() { return m_document.settings(); }, which is only
> used in ASSERTs and trivial to get rid of. I mean to do that in a following
> patch to push Document.h out of StyleResolver.h and into RenderObject.h, which
> is where the real challenge of header separation lies. (Solving that reduces
> recompilation by a lot, when I tried it hackishly.)

The documentSettings() removal landed, so I'll update this accordingly.

[Hajime Morrita, 2014-06-20 21:12:33]

rslgtm for core/, adding haraken and jochen for bindings/

[haraken, 2014-06-20 23:22:07]

LGTM for bindings/

[jochen (gone - plz use gerrit), 2014-06-24 08:57:31]

lgtm

[philipj_slow, 2014-06-24 09:35:11]

rebase

[philipj_slow, 2014-06-24 09:35:33]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-06-24 09:36:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/philipj@opera.com/344813003/80001

[commit-bot: I haz the power, 2014-06-24 10:39:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-24 11:17:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-24 11:17:59]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[philipj_slow, 2014-06-24 11:20:34]

Committed patchset #5 manually as r176831 (presubmit successful).