Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 344793009: Log errors from libusb. (Closed)

Created:
6 years, 6 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Log errors from libusb. Convert numeric error code from libusb into human readable strings and log them. Some of these errors should, in addition, be passed up to the running script. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278769

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -19 lines) Patch
M components/usb_service.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/usb_service/usb_context.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M components/usb_service/usb_device_handle_impl.cc View 8 chunks +33 lines, -8 lines 0 comments Download
M components/usb_service/usb_device_impl.cc View 4 chunks +12 lines, -6 lines 0 comments Download
A components/usb_service/usb_error.h View 1 chunk +18 lines, -0 lines 0 comments Download
A components/usb_service/usb_error.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M components/usb_service/usb_service_impl.cc View 4 chunks +16 lines, -2 lines 0 comments Download
M third_party/libusb/libusb.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Reilly Grant (use Gerrit)
6 years, 6 months ago (2014-06-19 21:57:20 UTC) #1
Ken Rockot(use gerrit already)
https://codereview.chromium.org/344793009/diff/1/components/usb_service/usb_error.cc File components/usb_service/usb_error.cc (right): https://codereview.chromium.org/344793009/diff/1/components/usb_service/usb_error.cc#newcode12 components/usb_service/usb_error.cc:12: return libusb_strerror((libusb_error)errcode); nit: Please use static_cast<libusb_error>(errorcode). No C-style casts.
6 years, 6 months ago (2014-06-19 23:09:37 UTC) #2
Reilly Grant (use Gerrit)
6 years, 6 months ago (2014-06-19 23:24:47 UTC) #3
Ken Rockot(use gerrit already)
On 2014/06/19 23:24:47, reillyg wrote: not lgtm
6 years, 6 months ago (2014-06-19 23:25:20 UTC) #4
Ken Rockot(use gerrit already)
lgtm
6 years, 6 months ago (2014-06-19 23:27:12 UTC) #5
Reilly Grant (use Gerrit)
The CQ bit was checked by reillyg@chromium.org
6 years, 6 months ago (2014-06-19 23:28:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/344793009/40001
6 years, 6 months ago (2014-06-19 23:30:48 UTC) #7
Reilly Grant (use Gerrit)
Bei Zhang, please review the libusb.gyp change.
6 years, 6 months ago (2014-06-20 00:49:06 UTC) #8
Ken Rockot(use gerrit already)
-ikarienator +meacer Bei is no longer on the project. Mustafa could you please take a ...
6 years, 6 months ago (2014-06-20 03:07:16 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 08:10:53 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 08:17:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/75082)
6 years, 6 months ago (2014-06-20 08:17:42 UTC) #12
meacer
libusb.gyp lgtm.
6 years, 6 months ago (2014-06-20 17:27:43 UTC) #13
Reilly Grant (use Gerrit)
The CQ bit was checked by reillyg@chromium.org
6 years, 6 months ago (2014-06-20 17:30:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/344793009/40001
6 years, 6 months ago (2014-06-20 17:30:58 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 18:14:02 UTC) #16
Message was sent while issue was closed.
Change committed as 278769

Powered by Google App Engine
This is Rietveld 408576698