components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java - Issue 344793006: Generate Cronet Version.java based on VERSION and LASTCHANGE files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

Issue 344793006: Generate Cronet Version.java based on VERSION and LASTCHANGE files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add Version to HttpUrlConnectionFactory.getName(). Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet.gypi ('k') | components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java » ('j') | components/cronet/android/url_request_peer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

diff --git a/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java b/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

index a0a243ea3d6040587368f235ccdd0e64f225cdb0..e83bf37f9640b01ae7076d04dd6e165be73952b1 100644

--- a/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

+++ b/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

@@ -28,7 +28,7 @@ class HttpUrlConnectionUrlRequestFactory extends HttpUrlRequestFactory {

@Override

public String getName() {

- return "HttpUrlConnection";

+ return "HttpUrlConnection/" + Version.getVersion();

}

@Override