components/cronet/android/url_request_context_peer.cc - Issue 344793006: Generate Cronet Version.java based on VERSION and LASTCHANGE files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/url_request_context_peer.cc

Issue 344793006: Generate Cronet Version.java based on VERSION and LASTCHANGE files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Matt's comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/android/url_request_context_peer.cc

diff --git a/components/cronet/android/url_request_context_peer.cc b/components/cronet/android/url_request_context_peer.cc

index df2cb4ede3f11144b1e0d4a61d9834568e9e2263..b1e047e2929717de19379ae7052768ed0d35e5dc 100644

--- a/components/cronet/android/url_request_context_peer.cc

+++ b/components/cronet/android/url_request_context_peer.cc

@@ -115,12 +115,10 @@ namespace cronet {

URLRequestContextPeer::URLRequestContextPeer(

URLRequestContextPeerDelegate* delegate,

std::string user_agent,

- int logging_level,

- const char* version) {

+ int logging_level) {

delegate_ = delegate;

user_agent_ = user_agent;

logging_level_ = logging_level;

- version_ = version;

}

void URLRequestContextPeer::Initialize(