components/cronet/cronet_version.h.version - Issue 344793006: Generate Cronet Version.java based on VERSION and LASTCHANGE files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/cronet/cronet_version.h.version

Issue 344793006: Generate Cronet Version.java based on VERSION and LASTCHANGE files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated HttpUrlRequestFactoryTest to expect correct version pattern in factory name. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CRONET_VERSION_H_

	6 #define CRONET_VERSION_H_

	7

	8 #define CRONET_VERSION "@MAJOR@.@MINOR@.@BUILD@.@PATCH@"

	9 #define LAST_CHANGE "@LASTCHANGE@"

	10 #define IS_OFFICIAL_BUILD @OFFICIAL_BUILD@
	mmenke 2014/06/19 19:45:28 I don't think @OFFICIAL_BUILD@ is a bool, but rath I don't think @OFFICIAL_BUILD@ is a bool, but rather a string, since it's used like: #define OFFICIAL_BUILD_STRING "@OFFICIAL_BUILD@" And using that to define a string that just contains false or true seems unlikely. mef 2014/06/19 21:23:29 FWIW The result in cronet_version.h is: #define IS Show quoted text On 2014/06/19 19:45:28, mmenke wrote: > I don't think @OFFICIAL_BUILD@ is a bool, but rather a string, since it's used > like: > > #define OFFICIAL_BUILD_STRING "@OFFICIAL_BUILD@" > > And using that to define a string that just contains false or true seems > unlikely. FWIW The result in cronet_version.h is: #define IS_OFFICIAL_BUILD 0
	11

	12 #endif // CRONET_VERSION_H_

OLD	NEW