Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 344793005: Fix flaky AppsGridViewTest on valgrind bot (Strike 2). (Closed)

Created:
6 years, 6 months ago by xiyuan
Modified:
6 years, 6 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Fix flaky AppsGridViewTest on valgrind bot (Strike 2). There is also a page transition animation to wait for after timer is fired. BUG=385167 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/app_list/views/test/apps_grid_view_test_api.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
xiyuan
6 years, 6 months ago (2014-06-19 16:16:54 UTC) #1
stevenjb
lgtm
6 years, 6 months ago (2014-06-19 16:53:15 UTC) #2
xiyuan
The CQ bit was checked by xiyuan@chromium.org
6 years, 6 months ago (2014-06-19 16:56:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/344793005/1
6 years, 6 months ago (2014-06-19 16:57:37 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 04:30:47 UTC) #5
Message was sent while issue was closed.
Change committed as 278591

Powered by Google App Engine
This is Rietveld 408576698