chrome/browser/notifications/notification.h - Issue 344763002: Rename notification_id() to disambiguate its meaning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification.h

Issue 344763002: Rename notification_id() to disambiguate its meaning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/message_center_notification_manager.cc ('k') | chrome/browser/notifications/notification_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification.h

diff --git a/chrome/browser/notifications/notification.h b/chrome/browser/notifications/notification.h

index 18997a697cc1cdfd9a0fd1b0bedb46e28b795241..d2a9d4aef8e87316a2a2fc024375e650899c5864 100644

--- a/chrome/browser/notifications/notification.h

+++ b/chrome/browser/notifications/notification.h

@@ -82,7 +82,8 @@ class Notification : public message_center::Notification {

// A url for the image to be shown (optional).

const GURL& image_url() const { return image_url_; }

- std::string notification_id() const { return delegate()->id(); }

+ // Id of the delegate embedded inside this instance.

+ std::string delegate_id() const { return delegate()->id(); }

int process_id() const { return delegate()->process_id(); }

content::WebContents* GetWebContents() const {