Rename notification_id() to disambiguate its meaning

ui/message_center/notification.h

Index: ui/message_center/notification.h
diff --git a/ui/message_center/notification.h b/ui/message_center/notification.h
index e151f4318259770dfcd2c6d4cb80af362455d607..fe5361bc08b96978542bc7f5e1e65d89ab98a863 100644
--- a/ui/message_center/notification.h
+++ b/ui/message_center/notification.h
@@ -64,12 +64,10 @@ class MESSAGE_CENTER_EXPORT Notification {
                const RichNotificationData& optional_fields,
                NotificationDelegate* delegate);
 
-  Notification(const Notification& other);
-
-  Notification& operator=(const Notification& other);
-
   virtual ~Notification();

[dewittj, 2014/06/19 17:01:23]

The changes in this file seem separate from the rest; is it an accidental
inclusion?

[juyik, 2014/06/19 17:12:05]

It was not a newly included. I just accidentally moved it upwards from the
original place: line 71. I have restored it now to avoid confusion.

 
+  Notification(const Notification& other);

[dewittj, 2014/06/19 17:01:23]

Could this be moved to protected as well?

[juyik, 2014/06/19 17:12:05]

I have tried it and found that it was used by other code.

+
   // Copies the internal on-memory state from |base|, i.e. shown_as_popup,
   // is_read, and never_timeout.
   void CopyState(Notification* base);
@@ -202,6 +200,8 @@ class MESSAGE_CENTER_EXPORT Notification {
       const base::Closure& click_callback);
 
  protected:
+  Notification& operator=(const Notification& other);
+
   // The type of notification we'd like displayed.
   NotificationType type_;