Rename notification_id() to disambiguate its meaning

Rename notification_id() to disambiguate its meaning.

As an intermediate step to disambiguate notifications
at notification UI manager level, we rename notification_id()
to delegate_id() to clarify that it is not an id for
notification in message center.

Also change assignment operator of message center's
notification to protected. Other members are still used by
notification list so they need to be public.

BUG=297867
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278593

[dewittj, 2014-06-19 17:01:23]

lgtm

https://codereview.chromium.org/344763002/diff/1/ui/message_center/notificati...
File ui/message_center/notification.h (right):

https://codereview.chromium.org/344763002/diff/1/ui/message_center/notificati...
ui/message_center/notification.h:67: virtual ~Notification();
The changes in this file seem separate from the rest; is it an accidental
inclusion?

https://codereview.chromium.org/344763002/diff/1/ui/message_center/notificati...
ui/message_center/notification.h:69: Notification(const Notification& other);
Could this be moved to protected as well?

[juyik, 2014-06-19 17:12:05]

https://codereview.chromium.org/344763002/diff/1/ui/message_center/notificati...
File ui/message_center/notification.h (right):

https://codereview.chromium.org/344763002/diff/1/ui/message_center/notificati...
ui/message_center/notification.h:67: virtual ~Notification();
On 2014/06/19 17:01:23, dewittj wrote:
> The changes in this file seem separate from the rest; is it an accidental
> inclusion?

It was not a newly included. I just accidentally moved it upwards from the
original place: line 71. I have restored it now to avoid confusion.

https://codereview.chromium.org/344763002/diff/1/ui/message_center/notificati...
ui/message_center/notification.h:69: Notification(const Notification& other);
On 2014/06/19 17:01:23, dewittj wrote:
> Could this be moved to protected as well?

I have tried it and found that it was used by other code.

[juyik, 2014-06-19 17:12:09]

The CQ bit was checked by juyik@chromium.org

[commit-bot: I haz the power, 2014-06-19 17:13:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/juyik@chromium.org/344763002/20001

[commit-bot: I haz the power, 2014-06-19 20:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-19 20:28:52]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[juyik, 2014-06-19 20:40:04]

The CQ bit was checked by juyik@chromium.org

[commit-bot: I haz the power, 2014-06-19 20:41:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/juyik@chromium.org/344763002/20001

[commit-bot: I haz the power, 2014-06-20 00:42:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[commit-bot: I haz the power, 2014-06-20 04:40:00]

Change committed as 278593