Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 344733003: Clean up ancestorScrollingLayer (Closed)

Created:
6 years, 6 months ago by Ian Vollick
Modified:
6 years, 6 months ago
Reviewers:
jamesr, abarth-chromium
CC:
abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Clean up ancestorScrollingLayer This function should have walked up the containing blocks rather than the parents. This cl fixes that and removes the useless ancestorCompositedScrollingLayer. Note: the layout test here was taken from abarth's patch https://codereview.chromium.org/340913002/ BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176520

Patch Set 1 : Make sure we pass Adam's layout test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -32 lines) Patch
A LayoutTests/compositing/overflow/scroll-parent-absolute.html View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/compositing/overflow/scroll-parent-absolute-expected.txt View 1 chunk +75 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 2 chunks +5 lines, -28 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Ian Vollick
As I was investigating https://codereview.chromium.org/340913002/, I noticed that ancestorScrollingLayer was busted and thought it'd be ...
6 years, 6 months ago (2014-06-19 05:37:47 UTC) #1
Ian Vollick
On 2014/06/19 05:37:47, Ian Vollick wrote: > As I was investigating https://codereview.chromium.org/340913002/, I noticed > ...
6 years, 6 months ago (2014-06-19 05:44:14 UTC) #2
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-19 16:00:26 UTC) #3
Ian Vollick
The CQ bit was checked by vollick@chromium.org
6 years, 6 months ago (2014-06-19 16:02:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/344733003/50001
6 years, 6 months ago (2014-06-19 16:03:36 UTC) #5
commit-bot: I haz the power
Change committed as 176520
6 years, 6 months ago (2014-06-19 16:07:09 UTC) #6
jamesr
The new layout test fails on mac: --- /b/build/slave/WebKit_Mac10_7/build/layout-test-results/compositing/overflow/scroll-parent-absolute-expected.txt +++ /b/build/slave/WebKit_Mac10_7/build/layout-test-results/compositing/overflow/scroll-parent-absolute-actual.txt @@ -30,12 +30,10 @@ ...
6 years, 6 months ago (2014-06-19 17:47:30 UTC) #7
Ian Vollick
6 years, 6 months ago (2014-06-19 19:28:42 UTC) #8
Message was sent while issue was closed.
On 2014/06/19 17:47:30, jamesr wrote:
> The new layout test fails on mac:
> 
> ---
>
/b/build/slave/WebKit_Mac10_7/build/layout-test-results/compositing/overflow/scroll-parent-absolute-expected.txt
> +++
>
/b/build/slave/WebKit_Mac10_7/build/layout-test-results/compositing/overflow/scroll-parent-absolute-actual.txt
> @@ -30,12 +30,10 @@
>              (GraphicsLayer
>                (position 0.00 485.00)
>                (bounds 485.00 15.00)
> -              (drawsContent 1)
>              )
>              (GraphicsLayer
>                (position 485.00 0.00)
>                (bounds 15.00 485.00)
> -              (drawsContent 1)
>              )
>              (GraphicsLayer
>                (position 485.00 485.00)
> 
> if this is expected, could you rebaseline?  If not, could you investigate?

Rebaseline is in the cq. Sigh, scrollbars. Sorry for this.

Powered by Google App Engine
This is Rietveld 408576698