Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 344703002: Revert of Remove EnableThreadedCompositing from the browser. (Closed)

Created:
6 years, 6 months ago by danakj
Modified:
6 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, creis+watch_chromium.org, nkostylev+watch_chromium.org, jdduke+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, jochen+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, enne (OOO), jamesr
Project:
chromium
Visibility:
Public.

Description

Revert of Remove EnableThreadedCompositing from the browser. (https://codereview.chromium.org/337783002/) Reason for revert: Broke virtual/implsidepainting/inspector/timeline, made them use single threaded compositor (and impl side painting). Original issue's description: > Remove EnableThreadedCompositing from the browser. > > Now only --disable-threaded-compositing exists, which is only present > for layout tests. The --enable-threaded-compositing flag moves to > become a content shell flag only, as it's only used for DumpRenderTree. > > Change any checks in the renderer process for kEnableThreadedCompositing > to instead be !kDisableThreadedCompositing since that is the only > flag left. > > Remove the whole threaded compositing thing from about:gpu and > about:flags. > > R=piman > BUG=384381, 346363 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278151 TBR=piman@chromium.org NOTREECHECKS=true NOTRY=true BUG=384381, 346363 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278178

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -29 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/compositor_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 4 chunks +29 lines, -1 line 0 comments Download
M content/browser/gpu/compositor_util_browsertest.cc View 1 chunk +25 lines, -7 lines 0 comments Download
M content/browser/renderer_host/input/touch_input_browsertest.cc View 2 chunks +16 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +4 lines, -2 lines 0 comments Download
M content/browser/resources/gpu/info_view.js View 2 chunks +7 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_android.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/common/shell_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/common/shell_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
danakj
Created Revert of Remove EnableThreadedCompositing from the browser.
6 years, 6 months ago (2014-06-18 21:05:34 UTC) #1
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 6 months ago (2014-06-18 21:06:00 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 6 months ago (2014-06-18 21:07:10 UTC) #3
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 6 months ago (2014-06-18 21:07:54 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 6 months ago (2014-06-18 21:07:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/344703002/1
6 years, 6 months ago (2014-06-18 21:08:39 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 21:11:25 UTC) #7
Message was sent while issue was closed.
Change committed as 278178

Powered by Google App Engine
This is Rietveld 408576698