Issue 344693003: Reduce forward declarations in core/svg

Issue 344693003: Reduce forward declarations in core/svg (Closed)

Created:
6 years, 6 months ago by rwlbuis

Modified:
6 years, 6 months ago

Reviewers:
pdr., f(malita)

CC:
blink-reviews, Eric Willigers, Steve Block, krit, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, fs, Timothy Loh, dstockwell, ed+blinkwatch_opera.com, shans, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, kouhei+svg_chromium.org, pdr.

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Reduce forward declarations in core/svg BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176460

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -42 lines)			Patch
M	Source/core/svg/SVGAltGlyphElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGAnimateMotionElement.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGAnimateTransformElement.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGAnimationElement.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/svg/SVGDocumentExtensions.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGFEDiffuseLightingElement.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGFilterPrimitiveStandardAttributes.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGFontElement.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGFontFaceElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGGlyphMap.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGInteger.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGNumberTearOff.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGPaint.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGParserUtilities.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGPathSegListSource.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGPathSegWithContext.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGPathUtilities.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGTests.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGTextContentElement.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGTransformTearOff.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGURIReference.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/graphics/SVGImage.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/graphics/SVGImageCache.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/graphics/filters/SVGFEImage.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/properties/SVGProperty.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

f(malita)

LGTM It would be interesting to know whether these are not needed because the classes ...

6 years, 6 months ago (2014-06-18 21:38:49 UTC) #2

rwlbuis

On 2014/06/18 21:38:49, Florin Malita wrote: > LGTM Thanks! > It would be interesting to ...

6 years, 6 months ago (2014-06-18 21:43:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/344693003/1

6 years, 6 months ago (2014-06-18 21:43:41 UTC) #5

Message was sent while issue was closed.

Change committed as 176460

Expand Messages | Collapse Messages