Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 344683002: Deleted testSporadicWrites IndexedDB performance test. (Closed)

Created:
6 years, 6 months ago by cmumford
Modified:
6 years, 6 months ago
Reviewers:
Nico, epenner, jsbell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Deleted testSporadicWrites IndexedDB performance test. These sporadic write tests introduced too much noise (too short a duration) and were not a good measure of IndexedDB performance. Note: This change will give the impression that IndexedDB performance has improved when there was no actual improvement because we track the aggregate test times. BUG=367855, 369683 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278467

Patch Set 1 #

Patch Set 2 : Removed reference to sporadic writes from test description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -95 lines) Patch
M chrome/test/data/indexeddb/perf_test.js View 2 chunks +0 lines, -94 lines 0 comments Download
M tools/perf/benchmarks/indexeddb_perf.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
cmumford
6 years, 6 months ago (2014-06-18 20:34:37 UTC) #1
jsbell
lgtm
6 years, 6 months ago (2014-06-18 21:09:08 UTC) #2
Nico
rslgtm
6 years, 6 months ago (2014-06-18 21:10:29 UTC) #3
cmumford
+epenner for review of indexeddb_perf.py. -nednguyen1 because I mistakenly added him thinking he could review ...
6 years, 6 months ago (2014-06-18 21:18:21 UTC) #4
epenner
On 2014/06/18 21:18:21, cmumford wrote: > +epenner for review of indexeddb_perf.py. -nednguyen1 because I mistakenly ...
6 years, 6 months ago (2014-06-18 21:39:21 UTC) #5
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 6 months ago (2014-06-19 16:40:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/344683002/20001
6 years, 6 months ago (2014-06-19 16:41:19 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 20:03:54 UTC) #8
Message was sent while issue was closed.
Change committed as 278467

Powered by Google App Engine
This is Rietveld 408576698